Opened 7 months ago

Closed 6 months ago

#28551 closed defect (implemented)

Tor's Travis should print the python version after installation

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords: tor-ci, travis, fast-fix
Cc: rl1987 Actual Points:
Parent ID: Points: 0.1
Reviewer: dgoulet Sponsor:

Description

If we don't print the actual python version that's running, diagnosing tickets like #28550 is more difficult.

We should print the version for all tests, because many tor tests use python.

Child Tickets

Change History (7)

comment:1 Changed 7 months ago by atagar

Parent ID: #28550

Dropping the parent because that's preventing me from resolving the other ticket.

comment:2 Changed 7 months ago by atagar

If we don't print the actual python version that's running,

Hi teor. Actually, Stem's tests should be doing this. Test runs are prefaced with versioning information...

% python3 run_tests.py --all
======================================================================
                             INITIALISING                             
======================================================================

  stem version...                                      1.7.0-dev
  tor version...                                       0.4.0.0-alpha-dev
  python version...                                    3.5.2
  operating system version...                          Linux (Ubuntu 16.04)
  cryptography version...                              missing
  pynacl version...                                    missing
  mock version...                                      1.0
  pyflakes version...                                  missing
  pycodestyle version...                               missing
  checking for orphaned .pyc files...                  done (0.0s)
  checking for unused tests...                         done (0.0s)
  importing test modules...                            done (0.1s)
  running pyflakes...                                  unavailable
  running pycodestyle...                               unavailable

======================================================================
                              UNIT TESTS                              
======================================================================

  util.enum...                                         success (0.00s)
  util.connection...                                   success (0.06s)
  util.conf...                                         success (0.02s)
...

comment:3 Changed 7 months ago by teor

Ok, but tor uses python for other tests, not just stem's tests.

comment:4 Changed 6 months ago by rl1987

Status: newneeds_review

comment:5 Changed 6 months ago by rl1987

Cc: rl1987 added

comment:6 Changed 6 months ago by dgoulet

Points: 0.1
Reviewer: dgoulet
Status: needs_reviewmerge_ready

Simple enough :). I can see it work properly in the CI. Thanks!

comment:7 Changed 6 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

lgtm too; merged!

Note: See TracTickets for help on using tickets.