Fix memory leaks and missing unmocks in test_entry_guard_outdated_dirserver_exclusion

test_entry_guard_outdated_dirserver_exclusion leaks memory, and is missing some unmocks

changed milestone to %Tor: 0.3.5.x-final

added 033-backport-maybe 034-backport-maybe 035-backport actualpoints::0.1 bootstrap clock-skew component::core tor/tor milestone::Tor: 0.3.5.x-final owner::teor parent::24661 points::0.1 priority::medium resolution::fixed reviewer::catalyst s8-bootstrap severity::normal sponsor::8-can status::closed type::defect version::tor 0.3.0.1-alpha labels

I included the fix in my #24661 (moved) branch, but we might want to backport it.

This ticket is sponsor8-can, because it fixes some unit tests we need for #24661 (moved).

See my pull request: https://github.com/torproject/tor/pull/534

Trac:
Points: N/A to 0.1
Sponsor: N/A to Sponsor8-can
Status: assigned to needs_review
Actualpoints: N/A to 0.1

This branch is based on maint-0.3.3.

The stem test will fail due to #28571 (closed), and the appveyor tests fail due to #28574 (moved).

Trac:
Reviewer: N/A to catalyst

Thanks! The pull request is against master, rather than 0.3.3, which appears to be the base branch. Would you like to adjust the pull request? Or is there some reason not to?

Trac:
Status: needs_review to needs_information

master is the default, and I wasn't paying attention.

Here's a pull request for 0.3.3: https://github.com/torproject/tor/pull/550

Here's a pull request for master, because 0.3.4 and later have Windows tests: https://github.com/torproject/tor/pull/534

I think we've fixed all the outstanding CI issues, so everything should pass.

Trac:
Status: needs_information to needs_review

Oh, hang on, the 0.3.3 pull request CI points to master for some reason. I think GitHub's CI API is broken, or it's broken on the Travis/Appveyor side.

Here's the 0.3.3 branch CI from my repository: https://travis-ci.org/teor2345/tor/builds/458279337

Replying to teor:

Oh, hang on, the 0.3.3 pull request CI points to master for some reason. I think GitHub's CI API is broken, or it's broken on the Travis/Appveyor side.

Here's the 0.3.3 branch CI from my repository: https://travis-ci.org/teor2345/tor/builds/458279337

It looks like your bug28554-033 and teor/bug28554 branches are identical for some reason? At least from what I fetch from GitHub.

$ git rev-parse teor/bug28554-033 teor/bug28554
ffc7b81b5dd909f0c4325e7a5b893504f76b9c77
ffc7b81b5dd909f0c4325e7a5b893504f76b9c77

Yes, the branches are identical:

Replying to teor:

This branch is based on maint-0.3.3.

OK weird. The Travis pages show the correct base branches, but attribute the build to the wrong pull request. Oddly enough, the links in the GitHub checks details go to the correct builds.

Patches look good to me. Thanks!

Trac:
Status: needs_review to merge_ready

Merged to 0.3.3 and forward!

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

changed time estimate to 48m

added 48m of time spent

moved to tpo/core/tor#28554 (closed)