Report relays that sbws wants to test, but the test doesn't work
We should count:
- the number of times sbws tries to test a relay
- the number of times the test works and fails
If there is a high number of failures, we should also count:
- the number of times that pair selection works and fails
- the number of times that connecting works and fails
- if there are a lot of these, count the hop that fails
- the number of times that data transfer works and fails
Activity
changed milestone to %sbws: 1.1.x-final
added changes-version-minor component::core tor/sbws milestone::sbws: 1.1.x-final owner::juga parent::28547 points::1 priority::medium resolution::implemented reviewer::nickm sbws-1.0-must-moved-20181128 sbws-110-proposed sbws-11x-final-removed-20190312 severity::normal status::closed tor-bwauth type::defect labels
Following the proposed KeyValues in https://pad.riseup.net/p/sbws-exclude-reasons-keep:
- any KeyValue that is based on the last bandwidth file adds more code complexity, because it would mean to read and parse the last bandwidth file
- i covered all the possible errors in
measure_relayand also store any error in callback error, so now any measurement attempt could be calculated as the sum of all measurements for a given relay - i created additional bandwidth lines KeyValues to report the reasons why the relays fail to be measured
Branch: https://github.com/juga0/sbws/tree/ticket28567
Not creating PR, not changing to merge_ready since master is not in 1.1.X version yet.
-
Replying to juga:
- i covered all the possible errors in
measure_relayand also store any error in callback error, so now any measurement attempt could be calculated as the sum of all measurements for a given relay
I thought it was not a good idea and actually it'd be better to don't have a callback error. Created new 2 commits explaining that.
- i covered all the possible errors in
-
https://github.com/torproject/sbws/pull/347
Trac:
Status: assigned to needs_review 
I think this is okay, but PLEASE document all functions, classes, fields, errors, etc. Right now I can only check that the code looks at least sort of reasonable -- not that it does what you want it to do. Documentation would let me know what you want the code to do, so I can check that it does that.
Trac:
Status: needs_review to needs_revisionIf we count all the times a relay has ever failed, that's ok. If we count all the times the relay failed in the last 5 days, that's also ok.
We just need to document the counters in the bandwidth-file-spec, I opened #29775 (moved) so we remember to do the documentation.
