Opened 2 years ago
Closed 23 months ago
#28573 closed enhancement (fixed)
Make testbuild target work for multi-locale Android
| Reported by: | gk | Owned by: | tbb-team |
|---|---|---|---|
| Priority: | Medium | Milestone: | |
| Component: | Applications/Tor Browser | Version: | |
| Severity: | Normal | Keywords: | tbb-rbm, TorBrowserTeam201812R |
| Cc: | boklm | Actual Points: | |
| Parent ID: | Points: | ||
| Reviewer: | Sponsor: |
Description
The testbuild target just provides a single bundle for our platforms to allow a quick test of changes without generating .mar files or localized bundles.
However, that currently breaks generating multi-locale Android .apks with the testbuild target as the step of ignoring non-en-US locales is not done at the packaging step but right from the beginning. The result is that the checkout and assembly of the firefox-locale-bundle is failing ("failing" in the sense that no or potentially the wrong localized files are zipped up; the build of the component itself is not failing).
Child Tickets
Change History (3)
comment:1 Changed 2 years ago by
| Keywords: | TorBrowserTeam201811R added; TorBrowserTeam201811 removed |
|---|---|
| Status: | new → needs_review |
comment:2 Changed 23 months ago by
| Keywords: | TorBrowserTeam201812R added; TorBrowserTeam201811R removed |
|---|
Move review tickets to Decemeber.
comment:3 Changed 23 months ago by
| Resolution: | → fixed |
|---|---|
| Status: | needs_review → closed |
Looks mostly good. I fixed some typos in the README.HACKING document to avoid another round trip and merged the patch to master (comit c359853bd44b320595d5a52fc4340ab3b6825d8d).
I added a patch in branch
bug_28573, keeping all locales in Android testbuild:https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_28573&id=bef73e142d0413518834757f2ad5de70dd33c02c