Opened 7 months ago

Closed 5 months ago

#28590 closed defect (fixed)

Replace sbws tests/integration/net.tar with an unpacked version

Reported by: teor Owned by:
Priority: Medium Milestone: sbws: 1.0.x-final
Component: Core Tor/sbws Version:
Severity: Normal Keywords: sbws-1.0-nice-moved-20181128
Cc: juga Actual Points:
Parent ID: Points:
Reviewer: ahf Sponsor:

Description

We don't put binary blobs in our git repositories. It makes diffs impossible. And it's a source of security issues.

Found while tracking down the commit that introduced #28588.

Child Tickets

Change History (11)

comment:1 Changed 7 months ago by teor

Milestone: sbws 1.0 (MVP must)sbws 1.0 (MVP nice)

This is nice to have

comment:2 Changed 7 months ago by teor

Keywords: sbws-1.0-nice-moved-20181128 added
Milestone: sbws 1.0 (MVP nice)sbws 1.0.4

Moving all sbws 1.0 nice tickets to 1.0.4

comment:3 Changed 7 months ago by teor

Milestone: sbws 1.0.4sbws 1.1

Milestone renamed

comment:4 Changed 7 months ago by teor

Milestone: sbws 1.1sbws: 1.1.x

Milestone renamed

comment:5 Changed 7 months ago by teor

Milestone: sbws: 1.1.xsbws: 1.1.x-final

Milestone renamed

comment:6 Changed 6 months ago by juga

Milestone: sbws: 1.1.x-finalsbws: 1.0.x-final

Moving to 1.0, since it's easy/fast to solve and will avoid continuing to distribute binaries in next release.

comment:7 Changed 6 months ago by juga

Status: newneeds_review

comment:8 Changed 6 months ago by dgoulet

Reviewer: ahf

comment:9 Changed 5 months ago by ahf

Status: needs_reviewmerge_ready

This looks fine as far as I can tell.

  • It looks like the files that have been extracted are the same as in the tarball.
  • I did NOT go over the individual files to see if some of the code or config files could get some clean-up.

Right now the Travis CI fails with what looks like an unrelated GPG failure. Please bump the Travis CI to make it pass before landing, but other than that it looks good to me.

comment:10 in reply to:  9 Changed 5 months ago by juga

Replying to ahf:

Right now the Travis CI fails with what looks like an unrelated GPG failure. Please bump the Travis CI to make it pass before landing, but other than that it looks good to me.

After restarting many time the travis job and still failing, i rebased to master (the key is not fetched anymore from the key servers) in https://github.com/juga0/sbws/tree/bug28590_rebased_master and stop failing.

comment:11 Changed 5 months ago by juga

Resolution: fixed
Status: merge_readyclosed

Merged

Note: See TracTickets for help on using tickets.