Opened 6 months ago

Closed 4 months ago

Last modified 3 months ago

#28618 closed defect (fixed)

Set MOZILLA_OFFICIAL on Windows builds

Reported by: gk Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, tbb-8.0-issues, tbb-regression, GeorgKoppen201901, TorBrowserTeam201901R
Cc: boklm, Crissy Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We needed to disable MOZILLA_OFFICIAL on Windows builds as those build were crashing with it. See: #27865. The underlying problem is using --gc-section in binutils 2.26.1 (See: https://bugzilla.mozilla.org/show_bug.cgi?id=1470772#c8). We should probably either backport the necessary binutils fix or (preferred) bump binutils to something > 2.26.1, which is, alas, currently blocked on https://sourceware.org/bugzilla/show_bug.cgi?id=23466. (See: #26148)

Child Tickets

Change History (14)

comment:1 Changed 6 months ago by gk

Note: while fixing this bug let's revert all the workaround we used for that problem so far, like the patches in #26476.

comment:2 Changed 6 months ago by gk

Keywords: tbb-8.0-issues GeorgKoppen201811 added; tbb-8.0.issues removed

comment:3 Changed 6 months ago by boklm

Keywords: tbb-rbm added; tbbm-rbm removed

comment:4 Changed 6 months ago by gk

Keywords: GeorgKoppen201812 added; GeorgKoppen201811 removed

Moving my tickets to December.

comment:5 Changed 6 months ago by gk

I got the 64-bit version working over the weekend but it seems we need yet another patch for 32-bit...

comment:6 Changed 5 months ago by gk

Keywords: TorBrowserTeam201812 added; TorBrowserTeam201811 removed

Moving our tickets to December.

comment:7 Changed 5 months ago by gk

Keywords: TorBrowserTeam201812R added; TorBrowserTeam201812 removed
Status: newneeds_review

Okay, it seems I got it all. I have two patches for review: one for tor-browser in bug_28618 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_28618&id=ed0d7b7528fec2330d9f4bd36348e86346062f75) and two for tor-browser-build (see: https://gitweb.torproject.org/user/gk/tor-browser-build.git/log/?h=bug_28618, commit b0f58a65361d14f8c60611541786f7a0ad2faff0 and df32ae91866f0594d9a6b48cc4bb267ec5a2d195).

comment:8 Changed 4 months ago by gk

Keywords: TorBrowserTeam201901R added; TorBrowserTeam201812R removed

Moving review tickets to 2019.

comment:9 Changed 4 months ago by gk

Keywords: GeorgKoppen201901 TorBrowserTeam201901 added; GeorgKoppen201812 TorBrowserTeam201901R removed
Status: needs_reviewneeds_revision

Now that the fix for #26148 landed, I should adapt the patches for this bug.

comment:10 Changed 4 months ago by gk

Keywords: TorBrowserTeam201901R added; TorBrowserTeam201901 removed
Status: needs_revisionneeds_review

bug_28168_v2 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_28618_v2&id=a72744a2d29cb8b17a20ff5fc5ee2d5ccc351fc5) in my tor-browser and bug_28168_v3 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/log/?h=bug_28168_v3, 2 commits) in my tor-browser-build repo are the simplified patches/branches to look at.

comment:11 Changed 4 months ago by mcs

r=brade, r=mcs
Maybe boklm should look at the these patches too, but they look good to us.

comment:12 in reply to:  11 Changed 4 months ago by boklm

Replying to mcs:

r=brade, r=mcs
Maybe boklm should look at the these patches too, but they look good to us.

This looks good to me too.

comment:13 Changed 4 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Merged to master in tor-browser-build (commit 55556eb3dd1869980fe733d56647e0307dd66fa1) and cherry-picked the browser patch to tor-browser-60.4.0esr-8.5-1 (commit 9daf30f059baff3af2f5b26ab6f60853f19516b2).

comment:14 Changed 3 months ago by gk

Cc: Crissy added
Note: See TracTickets for help on using tickets.