Set MOZILLA_OFFICIAL on Windows builds

We needed to disable MOZILLA_OFFICIAL on Windows builds as those build were crashing with it. See: #27865 (moved). The underlying problem is using --gc-section in binutils 2.26.1 (See: https://bugzilla.mozilla.org/show_bug.cgi?id=1470772#c8). We should probably either backport the necessary binutils fix or (preferred) bump binutils to something > 2.26.1, which is, alas, currently blocked on https://sourceware.org/bugzilla/show_bug.cgi?id=23466. (See: #26148 (moved))

added GeorgKoppen201901 TorBrowserTeam201901R component::applications/tor browser owner::tbb-team priority::high resolution::fixed severity::normal status::closed tbb-8.0-issues tbb-rbm tbb-regression type::defect labels

Note: while fixing this bug let's revert all the workaround we used for that problem so far, like the patches in #26476 (moved).

Trac:
Keywords: tbb-8.0.issues deleted, tbb-8.0-issues, GeorgKoppen201811 added

Trac:
Keywords: tbbm-rbm deleted, tbb-rbm added

Moving my tickets to December.

Trac:
Keywords: GeorgKoppen201811 deleted, GeorgKoppen201812 added

I got the 64-bit version working over the weekend but it seems we need yet another patch for 32-bit...

Moving our tickets to December.

Trac:
Keywords: TorBrowserTeam201811 deleted, TorBrowserTeam201812 added

Okay, it seems I got it all. I have two patches for review: one for tor-browser in bug_28618 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_28618&id=ed0d7b7528fec2330d9f4bd36348e86346062f75) and two for tor-browser-build (see: https://gitweb.torproject.org/user/gk/tor-browser-build.git/log/?h=bug_28618, commit b0f58a65361d14f8c60611541786f7a0ad2faff0 and df32ae91866f0594d9a6b48cc4bb267ec5a2d195).

Trac:
Keywords: TorBrowserTeam201812 deleted, TorBrowserTeam201812R added
Status: new to needs_review

Moving review tickets to 2019.

Trac:
Keywords: TorBrowserTeam201812R deleted, TorBrowserTeam201901R added

Now that the fix for #26148 (moved) landed, I should adapt the patches for this bug.

Trac:
Status: needs_review to needs_revision
Keywords: GeorgKoppen201812, TorBrowserTeam201901R deleted, TorBrowserTeam201901, GeorgKoppen201901 added

bug_28168_v2 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_28618_v2&id=a72744a2d29cb8b17a20ff5fc5ee2d5ccc351fc5) in my tor-browser and bug_28168_v3 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/log/?h=bug_28168_v3, 2 commits) in my tor-browser-build repo are the simplified patches/branches to look at.

Trac:
Keywords: TorBrowserTeam201901 deleted, TorBrowserTeam201901R added
Status: needs_revision to needs_review

r=brade, r=mcs Maybe boklm should look at the these patches too, but they look good to us.

Replying to mcs:

r=brade, r=mcs Maybe boklm should look at the these patches too, but they look good to us.

This looks good to me too.

Merged to master in tor-browser-build (commit 55556eb3dd1869980fe733d56647e0307dd66fa1) and cherry-picked the browser patch to tor-browser-60.4.0esr-8.5-1 (commit 9daf30f059baff3af2f5b26ab6f60853f19516b2).

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

Trac:
Cc: boklm to boklm, Crissy

closed

mentioned in issue #29514 (moved)

moved to tpo/applications/tor-browser#28618 (closed)