Opened 4 months ago

Closed 3 months ago

#28619 closed defect (fixed)

hs-v3: Do not close RP circuits when deleting an ephemeral service

Reported by: dgoulet Owned by:
Priority: High Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, 034-backport, 033-backport, 035-rc-blocker?
Cc: asn Actual Points:
Parent ID: Points:
Reviewer: asn Sponsor:

Description

Related to the OnionShare issue with v3:

https://lists.torproject.org/pipermail/tor-dev/2018-November/013556.html

The v2 subsystem doesn't close the RP circuits so our best move here is to do the same. The fix is trivial.

Child Tickets

Change History (8)

comment:1 Changed 4 months ago by dgoulet

Keywords: 035-backport removed
Milestone: Tor: 0.4.0.x-finalTor: 0.3.5.x-final

comment:2 Changed 4 months ago by dgoulet

Keywords: 035-rc added

comment:3 Changed 4 months ago by dgoulet

Cc: asn added
Status: newneeds_review

Should merge cleanly forward.

Branch: ticket28619_033_01
PR: https://github.com/torproject/tor/pull/546

comment:4 Changed 4 months ago by dgoulet

Reviewer: asn

comment:5 Changed 4 months ago by teor

Keywords: 035-rc-blocker? added; 035-rc removed

comment:6 Changed 4 months ago by asn

Status: needs_reviewmerge_ready

LGTM! And addresses the onionshare bug as verified by running the onion-bug script.

comment:7 Changed 4 months ago by nickm

Milestone: Tor: 0.3.5.x-finalTor: 0.3.4.x-final

Merged to 0.3.5; if nothing breaks, let's backport.

comment:8 Changed 3 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: 0.3.3.x-final
Resolution: fixed
Status: merge_readyclosed

Merged to 0.3.3 and forward.

Note: See TracTickets for help on using tickets.