Update Tor Browser Icon for Android
Now that we have updated icon assets, let's update the TBA icon for Android also
Activity
Trac:
Priority: Medium to High
Keywords: N/A deleted, TBA-a3 added
Parent: #25702 (moved) to N/A
Trac:
Parent: N/A to #27399 (moved)-
I started working on that yesterday and today and mainly cleaned-up directories. Antonela said she'll help with the mobile icons (thanks!). We need the following ones (taking the official ones as example):
32x32 and 64x64 favicons (see: https://dxr.mozilla.org/mozilla-esr60/source/mobile/android/branding/official/content)
and then a bunch of icons found in the
drawable-Xdpifolders (see: https://dxr.mozilla.org/mozilla-esr60/source/mobile/android/branding/official/res).In particular (for each of stable, alpha, and nightly, which we want to have for mobile as well at some point):
72x72 and 144x144 in hdpi 96x96 and 192x192 in xhdpi 144x144 and 288x288 (Mozilla has 300x300 for alpha and nightly icons instead) in xxhdpi 192x192 in xxxhdpi
Trac:
Status: new to needs_information -
Trac:
assets.zip -
Replying to antonela:
I attached the three container version available (circle, square large, square small) + all the required display density variables. Let me know if something else is needed.
Which icons should I use for the large versions of the hdpi/xhdpi/xxhdpi icons? And which for the 32x32 and 64x64 favicons? (see comment:10 for all the details, you can click the folders behind the links to check how the Mozilla icons look like)
Additionally, we need at least a set of alpha icons but we want to have nightly ones as well, like for desktop. I thought to ship the next alpha with the alpha series to give the same experience across platforms.
-
Trac:
assets_circle.zip -
Replying to antonela:
- Let's go with the circle version :)
Sure, although that was not my question. :) Mozilla is providing two versions of the icon for hdpi/xhdpi/xxhdpi but you only have one in your assets, See: comment:10 for the large dimensions. I don't know which icons I should use for those. I guess you'd still need to create them? (not sure what to do for the different sizes of the large icon for xxhdpi. Maybe just following Mozilla?)
- Added 32x32 and 64x64 favicon, not sure where are they applied on TBA. On desktop, it goes at the URL bar in about:tor but not sure here.
Those icons should be visible on some
aboutpages, see: https://dxr.mozilla.org/mozilla-esr60/search?q=favicon64. However, I've not figured out why this does not seem to work. I guess that's because of one of our patches. It would be nice to have those icons fixed now, though, to have them ready once we tackle the favicon bug (if there is any at all)- Added alpha and nightly versions too.
Thanks.
-
Trac:
res.zip -
Trac:
TBA_Icons.sketch -
Replying to antonela:
Georg, everything you needed were at the attachments. Anyways, I sorted it by folder so there is not confusion.
Thanks, but, no, the 288x288 icons were not there, which now seems to be fixed. \o/
Trac:
Status: needs_information to new -
Here is a build for testing how the icons look like in a nightly context:
https://people.torproject.org/~gk/testbuilds/tor-browser-tbb-nightly-android-armv7-multi-qa_28622_1.apk https://people.torproject.org/~gk/testbuilds/tor-browser-tbb-nightly-android-armv7-multi-qa_28622_1.apk.asc
Antonela: do we want to have that black border around the icons? (I guess: no?)
Trac:
Status: new to needs_information -
Replying to gk:
Here is a build for testing how the icons look like in a nightly context:
https://people.torproject.org/~gk/testbuilds/tor-browser-tbb-nightly-android-armv7-multi-qa_28622_1.apk https://people.torproject.org/~gk/testbuilds/tor-browser-tbb-nightly-android-armv7-multi-qa_28622_1.apk.asc
Antonela: do we want to have that black border around the icons? (I guess: no?)
Aha, so the black comes from the black parts of the onion. (The stable icon has a nice purple here which made me realize that).
Here is a bundle showing the alpha behavior:
https://people.torproject.org/~gk/testbuilds/tor-browser-8.5a10-alpha-android-armv7-multi-qa_28622.apk https://people.torproject.org/~gk/testbuilds/tor-browser-8.5a10-alpha-android-armv7-multi-qa_28622.apk.asc
Antonela: are we good with the look for alpha/nightly builds?
-
Replying to antonela:
Looks good. Should we update the orbot icon at the status bar? Could you share with me the assets it currently has?
I think we don't need to work on that because as I understand it sisbell's work that is blocking the next alpha should get rid of that icon. So, I'd wait for that to land before looking at the Orbot stuff (let me know whether you want to have the assets regardless).
Trac:
Status: needs_information to new -
Okay, for posterity here comes a test bundle that uses the stable icon (and "Tor Browser for Android"; just ignore the alpha version number):
https://people.torproject.org/~gk/testbuilds/tor-browser-8.5a10-stable-android-armv7-multi-qa.apk https://people.torproject.org/~gk/testbuilds/tor-browser-8.5a10-stable-android-armv7-multi-qa.apk.asc
-
bug_28622_v2(https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_28622_v2&id=300c55e5e0cf8e24f49959eababd2c7d9fc056ad) in mytor-browser-buildrepo contains the needed changes to our build scripts andbug_28622_v3(https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_28622_v3&id=f1a5708aa82fc832ec4e1d3529f18ae8ceaa217f) in mytor-browserrepository contains the meat of this ticket. Both are up for review.Trac:
Keywords: TorBrowserTeam201903 deleted, TorBrowserTeam201903R added
Status: new to needs_review 300c55e5e0cf8e24f49959eababd2c7d9fc056ad (tor-browser-build bug_28622_v2) - Seems ok
f1a5708aa82fc832ec4e1d3529f18ae8ceaa217f (tor-browser bug_28622_v3):
-ANDROID_PACKAGE_NAME=org.torproject.torbrowser_alpha MOZ_APP_DISPLAYNAME="Tor Browser for Android (Alpha)" +ANDROID_PACKAGE_NAME=org.torproject.torbrowser_alphaI'm guessing this isn't an important change.
I'll assume all of the binary changes are okay.
--- a/mobile/android/branding/torbrowser/locales/en-US/brand.dtd +++ b/mobile/android/branding/alpha/locales/en-US/brand.dtd @@ -2,8 +2,8 @@ - License, v. 2.0. If a copy of the MPL was not distributed with this - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> -<!ENTITY brandShortName "Tor Browser"> -<!ENTITY brandFullName "Tor Browser for Android"> -<!ENTITY vendorShortName "The Tor Project"> +<!ENTITY brandShortName "Nightly"> +<!ENTITY brandFullName "Mozilla Nightly"> +<!ENTITY vendorShortName "Mozilla">This doesn't seems like the result we want, right? Similarly, I'm guessing
mobile/android/branding/alpha/locales/en-US/brand.propertieswas copied frommobile/android/branding/nightly, should that use the same content as the old torbrowser file?--- a/mobile/android/branding/torbrowser/locales/en-US/brand.properties +++ /dev/null @@ -1,7 +0,0 @@ -# This Source Code Form is subject to the terms of the Mozilla Public -# License, v. 2.0. If a copy of the MPL was not distributed with this -# file, You can obtain one at http://mozilla.org/MPL/2.0/. - -#filter -brandShortName=Tor Browser -brandFullName=Tor Browser for Android--- /dev/null +++ b/mobile/android/branding/alpha/locales/en-US/brand.properties @@ -0,0 +1,6 @@ +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. + +brandShortName=Nightly +brandFullName=Mozilla NightlyTrac:
Status: needs_review to needs_information-
Replying to sysrqb:
300c55e5e0cf8e24f49959eababd2c7d9fc056ad (tor-browser-build bug_28622_v2) - Seems ok
f1a5708aa82fc832ec4e1d3529f18ae8ceaa217f (tor-browser bug_28622_v3):
{{{ -ANDROID_PACKAGE_NAME=org.torproject.torbrowser_alpha MOZ_APP_DISPLAYNAME="Tor Browser for Android (Alpha)" +ANDROID_PACKAGE_NAME=org.torproject.torbrowser_alpha }}}
I'm guessing this isn't an important change.
No, it's just aligning that file with the layout of the other
configure.shfiles (those for stable and nightly).I'll assume all of the binary changes are okay.
{{{ --- a/mobile/android/branding/torbrowser/locales/en-US/brand.dtd +++ b/mobile/android/branding/alpha/locales/en-US/brand.dtd @@ -2,8 +2,8 @@ - License, v. 2.0. If a copy of the MPL was not distributed with this - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
- - - + + + }}}
This doesn't seems like the result we want, right? Similarly, I'm guessing
mobile/android/branding/alpha/locales/en-US/brand.propertieswas copied frommobile/android/branding/nightly, should that use the same content as the old torbrowser file?Huh, you are right. I am not sure how this happened, sorry for that. I pushed a fixup commit (2ee3e339625a403e6f92618a272264d7353aefdf) on the same branch that should correct this for all supported series, that is stable (aka official), alpha, and nightly. I am following here the desktop lead and don't differentiate the brand names based on series but using the same for all three.
Trac:
Status: needs_information to needs_review Replying to gk:
Replying to sysrqb: [snip]
f1a5708aa82fc832ec4e1d3529f18ae8ceaa217f (tor-browser bug_28622_v3):
-ANDROID_PACKAGE_NAME=org.torproject.torbrowser_alpha MOZ_APP_DISPLAYNAME="Tor Browser for Android (Alpha)" +ANDROID_PACKAGE_NAME=org.torproject.torbrowser_alpha }}} I'm guessing this isn't an important change.No, it's just aligning that file with the layout of the other
configure.shfiles (those for stable and nightly).Okay.
[snip]
This doesn't seems like the result we want, right? Similarly, I'm guessing
mobile/android/branding/alpha/locales/en-US/brand.propertieswas copied frommobile/android/branding/nightly, should that use the same content as the old torbrowser file?Huh, you are right. I am not sure how this happened, sorry for that. I pushed a fixup commit (2ee3e339625a403e6f92618a272264d7353aefdf) on the same branch that should correct this for all supported series,
Thanks, looks good.
that is stable (aka official), alpha, and nightly. I am following here the desktop lead and don't differentiate the brand names based on series but using the same for all three.
Ah, okay, that was one of my questions. My other question is: Do we want to follow Mozilla's lead with the naming in terms of dropping the "for Android" tag? Looking a little closer at this, it seems Mozilla used "Firefox for Android" only internally, and they branded Fennec as Mozilla Firefox (and Firefox for the short name) externally. I don't have much of a preference here.
{{{ --- a/mobile/android/branding/official/locales/en-US/brand.properties +++ b/mobile/android/branding/official/locales/en-US/brand.properties @@ -2,5 +2,5 @@
License, v. 2.0. If a copy of the MPL was not distributed with this
file, You can obtain one at http://mozilla.org/MPL/2.0/.
-brandShortName=Firefox -brandFullName=Mozilla Firefox +brandShortName=Tor Browser +brandFullName=Tor Browser for Android
and--- a/mobile/android/branding/official/configure.sh +++ b/mobile/android/branding/official/configure.sh @@ -2,10 +2,7 @@
License, v. 2.0. If a copy of the MPL was not distributed with this
file, You can obtain one at http://mozilla.org/MPL/2.0/.
-MOZ_APP_DISPLAYNAME=Firefox -ANDROID_PACKAGE_NAME=org.mozilla.firefox +MOZ_APP_DISPLAYNAME="Tor Browser for Android" +ANDROID_PACKAGE_NAME=org.torproject.torbrowser
I haven't built all of the series with tor-browser-build, but the changes look good to me.-
Thanks. I've cherry-picked the patches onto
tor-browser-60.6.1esr-8.5-1(commit 099b6fcae28c60e96e7c24fd54ca7da14b00510f and 80e82b14804f677dd89a63a79d42f420ab9ccb7d). And opened a ticket for the "Tor Browser" vs. "Tor Browser for Android" question for 8.5 (#30136 (moved)).Trac:
Status: needs_review to closed
Resolution: N/A to fixed -
Trac:
no-mask.zip -
Trac:
512.zip mentioned in issue #30136 (moved)
mentioned in issue tpo/applications/tor-browser#30136 (closed)