Opened 5 months ago

Closed 9 days ago

#28622 closed task (fixed)

Update Tor Browser Icon for Android

Reported by: pili Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ux-team, tbb-mobile, TBA-a3, tbb-parity, tbb-8.5-must-alpha, TorBrowserTeam201904R, GeorgKoppen201904
Cc: tbb-team, antonela Actual Points:
Parent ID: #27399 Points:
Reviewer: Sponsor:

Description

Now that we have updated icon assets, let's update the TBA icon for Android also

Child Tickets

Attachments (4)

assets.zip (538.2 KB) - added by antonela 4 weeks ago.
assets_circle.zip (563.1 KB) - added by antonela 4 weeks ago.
res.zip (482.4 KB) - added by antonela 3 weeks ago.
TBA Icons.sketch (337.9 KB) - added by antonela 3 weeks ago.

Download all attachments as: .zip

Change History (37)

comment:1 Changed 5 months ago by gk

Keywords: TorBrowserTeam201811 added; TorBrowserTeam201811R removed

comment:2 Changed 5 months ago by gk

Keywords: TorBrowserTeam201812 added; TorBrowserTeam201811 removed

Moving items to December

comment:3 Changed 3 months ago by gk

Keywords: TorBrowserTeam201901 added; TorBrowserTeam201812 removed

Moving tickets to Jan 2019.

comment:4 Changed 3 months ago by gk

Keywords: TBA-a3 added
Parent ID: #25702
Priority: MediumHigh

comment:5 Changed 2 months ago by gk

Keywords: TorBrowserTeam201902 added; TorBrowserTeam201901 removed

Moving tickets to February.

comment:6 Changed 6 weeks ago by gk

Keywords: TorBrowserTeam201903 added; TorBrowserTeam201902 removed

Moving remaining tickets to March.

comment:7 Changed 6 weeks ago by gk

Keywords: tbb-8.5 added

Tickets on our radar for 8.5

comment:8 Changed 5 weeks ago by gk

Keywords: tbb-parity added

Introducing tbb-parity.

comment:9 Changed 5 weeks ago by antonela

Parent ID: #27399

comment:10 Changed 4 weeks ago by gk

Status: newneeds_information

I started working on that yesterday and today and mainly cleaned-up directories. Antonela said she'll help with the mobile icons (thanks!). We need the following ones (taking the official ones as example):

32x32 and 64x64 favicons (see: https://dxr.mozilla.org/mozilla-esr60/source/mobile/android/branding/official/content)

and then a bunch of icons found in the drawable-Xdpifolders (see: https://dxr.mozilla.org/mozilla-esr60/source/mobile/android/branding/official/res).

In particular (for each of stable, alpha, and nightly, which we want to have for mobile as well at some point):

72x72 and 144x144 in hdpi
96x96 and 192x192 in xhdpi
144x144 and 288x288 (Mozilla has 300x300 for alpha and nightly icons instead) in xxhdpi
192x192 in xxxhdpi

comment:11 Changed 4 weeks ago by gk

Cc: antonela added

comment:12 Changed 4 weeks ago by gk

Keywords: tbb-8.5-must added; tbb-8.5 removed

Marking blockers for Tor Browser 8.5.

comment:13 Changed 4 weeks ago by gk

Keywords: tbb-8.5-must-alpha added; tbb-8.5-must removed

Tickets that block the next 8.5 alpha.

comment:14 Changed 4 weeks ago by gk

Keywords: GeorgKoppen201903 added

Changed 4 weeks ago by antonela

Attachment: assets.zip added

comment:15 Changed 4 weeks ago by antonela

I attached the three container version available (circle, square large, square small) + all the required display density variables. Let me know if something else is needed.

comment:16 in reply to:  15 Changed 4 weeks ago by gk

Replying to antonela:

I attached the three container version available (circle, square large, square small) + all the required display density variables. Let me know if something else is needed.

Which icons should I use for the large versions of the hdpi/xhdpi/xxhdpi icons? And which for the 32x32 and 64x64 favicons? (see comment:10 for all the details, you can click the folders behind the links to check how the Mozilla icons look like)

Additionally, we need at least a set of alpha icons but we want to have nightly ones as well, like for desktop. I thought to ship the next alpha with the alpha series to give the same experience across platforms.

Changed 4 weeks ago by antonela

Attachment: assets_circle.zip added

comment:17 Changed 4 weeks ago by antonela

  • Let's go with the circle version :)
  • Added 32x32 and 64x64 favicon, not sure where are they applied on TBA. On desktop, it goes at the URL bar in about:tor but not sure here.
  • Added alpha and nightly versions too.
Last edited 4 weeks ago by antonela (previous) (diff)

comment:18 in reply to:  17 Changed 3 weeks ago by gk

Replying to antonela:

  • Let's go with the circle version :)

Sure, although that was not my question. :) Mozilla is providing two versions of the icon for hdpi/xhdpi/xxhdpi but you only have one in your assets, See: comment:10 for the large dimensions. I don't know which icons I should use for those. I guess you'd still need to create them? (not sure what to do for the different sizes of the large icon for xxhdpi. Maybe just following Mozilla?)

  • Added 32x32 and 64x64 favicon, not sure where are they applied on TBA. On desktop, it goes at the URL bar in about:tor but not sure here.

Those icons should be visible on some about pages, see: https://dxr.mozilla.org/mozilla-esr60/search?q=favicon64. However, I've not figured out why this does not seem to work. I guess that's because of one of our patches. It would be nice to have those icons fixed now, though, to have them ready once we tackle the favicon bug (if there is any at all)

  • Added alpha and nightly versions too.

Thanks.

Changed 3 weeks ago by antonela

Attachment: res.zip added

comment:19 Changed 3 weeks ago by antonela

Georg, everything you needed were at the attachments. Anyways, I sorted it by folder so there is not confusion.

Changed 3 weeks ago by antonela

Attachment: TBA Icons.sketch added

comment:20 Changed 3 weeks ago by antonela

And, attached is the sketch file, for some random future person who needs to deal with this.

comment:21 in reply to:  19 Changed 3 weeks ago by gk

Status: needs_informationnew

Replying to antonela:

Georg, everything you needed were at the attachments. Anyways, I sorted it by folder so there is not confusion.

Thanks, but, no, the 288x288 icons were not there, which now seems to be fixed. \o/

comment:22 Changed 3 weeks ago by gk

Status: newneeds_information

Here is a build for testing how the icons look like in a nightly context:

https://people.torproject.org/~gk/testbuilds/tor-browser-tbb-nightly-android-armv7-multi-qa_28622_1.apk
https://people.torproject.org/~gk/testbuilds/tor-browser-tbb-nightly-android-armv7-multi-qa_28622_1.apk.asc

Antonela: do we want to have that black border around the icons? (I guess: no?)

comment:23 in reply to:  22 Changed 3 weeks ago by gk

Replying to gk:

Here is a build for testing how the icons look like in a nightly context:

https://people.torproject.org/~gk/testbuilds/tor-browser-tbb-nightly-android-armv7-multi-qa_28622_1.apk
https://people.torproject.org/~gk/testbuilds/tor-browser-tbb-nightly-android-armv7-multi-qa_28622_1.apk.asc

Antonela: do we want to have that black border around the icons? (I guess: no?)

Aha, so the black comes from the black parts of the onion. (The stable icon has a nice purple here which made me realize that).

Here is a bundle showing the alpha behavior:

https://people.torproject.org/~gk/testbuilds/tor-browser-8.5a10-alpha-android-armv7-multi-qa_28622.apk
https://people.torproject.org/~gk/testbuilds/tor-browser-8.5a10-alpha-android-armv7-multi-qa_28622.apk.asc

Antonela: are we good with the look for alpha/nightly builds?

comment:24 Changed 3 weeks ago by antonela

Looks good. Should we update the orbot icon at the status bar? Could you share with me the assets it currently has?

comment:25 in reply to:  24 Changed 3 weeks ago by gk

Status: needs_informationnew

Replying to antonela:

Looks good. Should we update the orbot icon at the status bar? Could you share with me the assets it currently has?

I think we don't need to work on that because as I understand it sisbell's work that is blocking the next alpha should get rid of that icon. So, I'd wait for that to land before looking at the Orbot stuff (let me know whether you want to have the assets regardless).

comment:26 Changed 3 weeks ago by gk

Okay, for posterity here comes a test bundle that uses the stable icon (and "Tor Browser for Android"; just ignore the alpha version number):

https://people.torproject.org/~gk/testbuilds/tor-browser-8.5a10-stable-android-armv7-multi-qa.apk
https://people.torproject.org/~gk/testbuilds/tor-browser-8.5a10-stable-android-armv7-multi-qa.apk.asc

comment:27 Changed 3 weeks ago by gk

Keywords: TorBrowserTeam201903R added; TorBrowserTeam201903 removed
Status: newneeds_review

bug_28622_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_28622_v2&id=300c55e5e0cf8e24f49959eababd2c7d9fc056ad) in my tor-browser-build repo contains the needed changes to our build scripts and bug_28622_v3 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_28622_v3&id=f1a5708aa82fc832ec4e1d3529f18ae8ceaa217f) in my tor-browser repository contains the meat of this ticket. Both are up for review.

comment:28 Changed 3 weeks ago by gk

Keywords: TorBrowserTeam201904R added; TorBrowserTeam201903R removed

Moving review tickets to April.

comment:29 Changed 12 days ago by gk

Keywords: GeorgKoppen201904 added; GeorgKoppen201903 removed

Moving my tickets for April

comment:30 Changed 10 days ago by sysrqb

Status: needs_reviewneeds_information

300c55e5e0cf8e24f49959eababd2c7d9fc056ad (tor-browser-build bug_28622_v2) - Seems ok

f1a5708aa82fc832ec4e1d3529f18ae8ceaa217f (tor-browser bug_28622_v3):

-ANDROID_PACKAGE_NAME=org.torproject.torbrowser_alpha
 MOZ_APP_DISPLAYNAME="Tor Browser for Android (Alpha)"
+ANDROID_PACKAGE_NAME=org.torproject.torbrowser_alpha

I'm guessing this isn't an important change.

I'll assume all of the binary changes are okay.

--- a/mobile/android/branding/torbrowser/locales/en-US/brand.dtd
+++ b/mobile/android/branding/alpha/locales/en-US/brand.dtd
@@ -2,8 +2,8 @@
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
-<!ENTITY  brandShortName  "Tor Browser">
-<!ENTITY  brandFullName   "Tor Browser for Android">
-<!ENTITY  vendorShortName "The Tor Project">
+<!ENTITY  brandShortName  "Nightly">
+<!ENTITY  brandFullName   "Mozilla Nightly">
+<!ENTITY  vendorShortName "Mozilla">

This doesn't seems like the result we want, right? Similarly, I'm guessing mobile/android/branding/alpha/locales/en-US/brand.properties was copied from mobile/android/branding/nightly, should that use the same content as the old torbrowser file?

--- a/mobile/android/branding/torbrowser/locales/en-US/brand.properties
+++ /dev/null
@@ -1,7 +0,0 @@
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-
-#filter
-brandShortName=Tor Browser
-brandFullName=Tor Browser for Android
--- /dev/null
+++ b/mobile/android/branding/alpha/locales/en-US/brand.properties
@@ -0,0 +1,6 @@
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+brandShortName=Nightly
+brandFullName=Mozilla Nightly

comment:31 in reply to:  30 ; Changed 10 days ago by gk

Status: needs_informationneeds_review

Replying to sysrqb:

300c55e5e0cf8e24f49959eababd2c7d9fc056ad (tor-browser-build bug_28622_v2) - Seems ok

f1a5708aa82fc832ec4e1d3529f18ae8ceaa217f (tor-browser bug_28622_v3):

-ANDROID_PACKAGE_NAME=org.torproject.torbrowser_alpha
 MOZ_APP_DISPLAYNAME="Tor Browser for Android (Alpha)"
+ANDROID_PACKAGE_NAME=org.torproject.torbrowser_alpha

I'm guessing this isn't an important change.

No, it's just aligning that file with the layout of the other configure.sh files (those for stable and nightly).

I'll assume all of the binary changes are okay.

--- a/mobile/android/branding/torbrowser/locales/en-US/brand.dtd
+++ b/mobile/android/branding/alpha/locales/en-US/brand.dtd
@@ -2,8 +2,8 @@
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
-<!ENTITY  brandShortName  "Tor Browser">
-<!ENTITY  brandFullName   "Tor Browser for Android">
-<!ENTITY  vendorShortName "The Tor Project">
+<!ENTITY  brandShortName  "Nightly">
+<!ENTITY  brandFullName   "Mozilla Nightly">
+<!ENTITY  vendorShortName "Mozilla">

This doesn't seems like the result we want, right? Similarly, I'm guessing mobile/android/branding/alpha/locales/en-US/brand.properties was copied from mobile/android/branding/nightly, should that use the same content as the old torbrowser file?

Huh, you are right. I am not sure how this happened, sorry for that. I pushed a fixup commit (2ee3e339625a403e6f92618a272264d7353aefdf) on the same branch that should correct this for all supported series, that is stable (aka official), alpha, and nightly. I am following here the desktop lead and don't differentiate the brand names based on series but using the same for all three.

comment:32 in reply to:  31 Changed 10 days ago by sysrqb

Replying to gk:

Replying to sysrqb:

[snip]

f1a5708aa82fc832ec4e1d3529f18ae8ceaa217f (tor-browser bug_28622_v3):

-ANDROID_PACKAGE_NAME=org.torproject.torbrowser_alpha
 MOZ_APP_DISPLAYNAME="Tor Browser for Android (Alpha)"
+ANDROID_PACKAGE_NAME=org.torproject.torbrowser_alpha

I'm guessing this isn't an important change.

No, it's just aligning that file with the layout of the other configure.sh files (those for stable and nightly).

Okay.


[snip]

This doesn't seems like the result we want, right? Similarly, I'm guessing mobile/android/branding/alpha/locales/en-US/brand.properties was copied from mobile/android/branding/nightly, should that use the same content as the old torbrowser file?

Huh, you are right. I am not sure how this happened, sorry for that. I pushed a fixup commit (2ee3e339625a403e6f92618a272264d7353aefdf) on the same branch that should correct this for all supported series,

Thanks, looks good.

that is stable (aka official), alpha, and nightly. I am following here the desktop lead and don't differentiate the brand names based on series but using the same for all three.

Ah, okay, that was one of my questions. My other question is: Do we want to follow Mozilla's lead with the naming in terms of dropping the "for Android" tag? Looking a little closer at this, it seems Mozilla used "Firefox for Android" only internally, and they branded Fennec as Mozilla Firefox (and Firefox for the short name) externally. I don't have much of a preference here.

--- a/mobile/android/branding/official/locales/en-US/brand.properties
+++ b/mobile/android/branding/official/locales/en-US/brand.properties
@@ -2,5 +2,5 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-brandShortName=Firefox
-brandFullName=Mozilla Firefox
+brandShortName=Tor Browser
+brandFullName=Tor Browser for Android

and

--- a/mobile/android/branding/official/configure.sh
+++ b/mobile/android/branding/official/configure.sh
@@ -2,10 +2,7 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-MOZ_APP_DISPLAYNAME=Firefox
-ANDROID_PACKAGE_NAME=org.mozilla.firefox
+MOZ_APP_DISPLAYNAME="Tor Browser for Android"
+ANDROID_PACKAGE_NAME=org.torproject.torbrowser

I haven't built all of the series with tor-browser-build, but the changes look good to me.

comment:33 Changed 9 days ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. I've cherry-picked the patches onto tor-browser-60.6.1esr-8.5-1 (commit 099b6fcae28c60e96e7c24fd54ca7da14b00510f and 80e82b14804f677dd89a63a79d42f420ab9ccb7d). And opened a ticket for the "Tor Browser" vs. "Tor Browser for Android" question for 8.5 (#30136).

Note: See TracTickets for help on using tickets.