Introduce New Security Settings to users
The proposal includes a section 3. which contemplates the way we are informing users about the new behavior.
Activity
Hi everyone!
As per #25658 (moved) antonela's asked me to consider changes to the onboarding process to bring it in line with the new Security Preferences screen (replacing the existing security slider in TB).
Option 1: feature tour
https://sketch.cloud/s/q8JlM/bgO0ze4/play
Following the behaviour introduced to the user in the Circuit Display onboarding card:
- Hitting the purple button in the onboarding flow opens DDG in a new tab.
- A doorhanger introduces the new shield icon and explains the various icon states (the first sentence could be cut and/or incorporated into the onboarding card itself for brevity).
- Hitting "Next" opens the Security Level doorhanger (see the change in icon state) and the second and third steps of the feature tour.
- User may hit "Advanced Security Settings" at any time to open the new Security Preferences screen in a new tab (still in design as per #25658 (moved)).
- Hitting "Done!" at the end of the feature tour returns the user to the Security card in About:Tor.
The intention of this route is to introduce the new shield icon and Security Level doorhanger properly and provide more context for the Security Preferences screen itself.
Option 2: simple fix
https://sketch.cloud/s/q8JlM/QbkaV97/play
- Hitting the purple button in the onboarding flow simply opens the new Security Preferences screen in a new tab, instead of the current security slider window.
Full .sketch file here for reference: https://sketch.cloud/s/q8JlM
On a related note I think it would be worthwhile adding an icon or other device to the purple buttons in the onboarding flow, to differentiate between the two button behaviours:
a) Button progresses to the next card b) Button opens an external link/feature tour
But perhaps that should be a new ticket?
hey dunqan! Thanks for working on it!
Personally, I would like to keep the user in the same tab. Mainly, because we got some interesting feedback (#27486 (moved), #27484 (moved)) from the circuit display walking through and will be a smart move if we can run it directly at
about:tor.My suggestion is to have a [See your security level] (or similar) button instead of [Review your security]. When user hits then the doorhanger shows up. It will looks similar of what firefox is doing at [Show Address Bar] in FF63.
With this iteration, then #27485 (moved) will be covered.
GeKo, mcs, what do you think?
Replying to antonela:
hey dunqan! Thanks for working on it!
Personally, I would like to keep the user in the same tab. Mainly, because we got some interesting feedback (#27486 (moved), #27484 (moved)) from the circuit display walking through and will be a smart move if we can run it directly at
about:tor.+1
My suggestion is to have a [See your security level] (or similar) button instead of [Review your security]. When user hits then the doorhanger shows up. It will looks similar of what firefox is doing at [Show Address Bar] in FF63.
With this iteration, then #27485 (moved) will be covered.
GeKo, mcs, what do you think?
Sounds like a good plan to me.
-
Thanks both, 100% agree. Have updated the following:
Option 1: feature tour
https://sketch.cloud/s/q8JlM/52bG3jL/play
- Button now reads "See your security level"
- Doorhangers now open in the same tab
Option 2: simple fix
https://sketch.cloud/s/q8JlM/nRVdjEz/play
- Button now reads "See your security level"
- Button now opens the Security level doorhanger, instead of the Security Preferences screen directly
-
I think we should go with the Option 2.
Prototype https://sketch.cloud/s/q8JlM/nRVdjEz/play
Behaviour During the onboarding, users click on
[See Your Security Level]and the doorhanger gets open. -
mcs/brade: Could you think about that ticket while reviewing #25658 (moved)?
Trac:
Keywords: TorBrowserTeam201902 deleted, TorBrowserTeam201903 added
Cc: N/A to mcs, brade 
Here is a tor-browser patch that implements the behavior described in comment:10: https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug28628-01&id=31f3234345656a73a8f1ccd50d1ab04760d57cc7
And here is a patch for Torbutton (to add the revised button label): https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug28628-01&id=fe11a594f40310efd45d5695c5b5214a6dad4a37
Trac:
Status: assigned to needs_review
Keywords: TorBrowserTeam201903 deleted, TorBrowserTeam201903R added-
Replying to mcs:
Here is a tor-browser patch that implements the behavior described in comment:10:
Just to be clear here: this implements a new button and opening the panel from the toolbar, right? But it does not do the full behavior outlined in the prototype yet. If so, antonela, is the prototype not up-to-date anymore (in the sense that it is showing steps 1/3, 2/3, and 3/3 similar to the circuit display but we went for a simpler version)?
Trac:
Status: needs_review to needs_information -
Replying to gk:
Just to be clear here: this implements a new button and opening the panel from the toolbar, right? But it does not do the full behavior outlined in the prototype yet. If so, antonela, is the prototype not up-to-date anymore (in the sense that it is showing steps 1/3, 2/3, and 3/3 similar to the circuit display but we went for a simpler version)?
Maybe I am confused, but yes I thought the simple version was what Antonela decided we should use (comment:5 Option 2).
Trac:
Status: needs_information to needs_review -
I cherry-picked the Torbutton patch (commit 52c12d905ff4f6d35d5788b5cc379e474be429e9 on
torbutton'smaster) and the tor-browser patch (commit ea65909a1c1060e544ea56a110f948994e2a3df9 ontor-browser'stor-browser-60.5.1esr-8.5-1).We'll deal with the more general question of introducing new features in #29768 (moved).
Trac:
Status: needs_review to closed
Resolution: N/A to fixed
