Changes between Version 1 and Version 2 of Ticket #28634, comment 21


Ignore:
Timestamp:
May 7, 2019, 8:15:17 PM (5 months ago)
Author:
mikeperry
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28634, comment 21

    v1 v2  
    996. Let's always use CIRCPAD_TOKEN_REMOVAL_NONE (and never use_rtt_estimate), so I can write a version of #29085 that does not cause us to call monotime when these modes are used (so we don't have to worry about that overhead for these machines). If you want to add a CIRCPAD_DIST_FIXED that always returns the value of param1 for use as a length_dist, that might be the cleanest way to avoid token removal for 1 token (rather than making a hacky use of CIRCPAD_DIST_UNIFORM to return rand(1,1)).
    1010
    11 I will work on #28780 and #29085 this week under the above assumptions. Can you take care of the above for the machines in this ticket?
     11I will work on #28780 and #29085 this week under the above assumptions. Can you take care of the above for the machines in this ticket? (Note the above items are not ordered in any kind of importance or priority nor am I trying to make binding decrees; I'm just trying to summarize. In particular: the state naming thing is not as important as the others and it if it is annoying and time consuming or you disagree, just skip it).