Opened 7 months ago

Last modified 7 months ago

#28643 new task

New github team for manual and support

Reported by: teor Owned by: hiro
Priority: Medium Milestone:
Component: Internal Services/Service - github tpo Version:
Severity: Normal Keywords:
Cc: emmapeel Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

emmapeel asked me to give her write access to the manual and support repositories on https://github.com/torproject , so she can close pull requests.

We give access to github/torproject using github teams.

People with write access can close pull requests, and push to branches.

Here's what I need to know:

Write access team:
Which repositories should the team have access to?
What should the team be called?
Who should be in the team?
What are their github usernames?

Do you need a team with admin access as well?
People with admin access can modify permissions, and delete or rename the repository. (A few of us already have admin access to all repositories.)

Child Tickets

Change History (2)

comment:1 Changed 7 months ago by hiro

emmapeel should be able to push to torgit and then the git hooks we have should push to github and automagically close the pull request.

We give read access to github/torproject teams so that when a PR is opened people can receive an email on that repository (because they are in the team). Then I only give write access to the pusher, which is only an account we use to sync between torgit and github.

I am going to check why this PR isn't being closed automatically. Sometimes github is slow in syncing PR, the only important thing is that once something is merged the commits can be seen on github.

comment:2 in reply to:  1 Changed 7 months ago by teor

Replying to hiro:

emmapeel should be able to push to torgit and then the git hooks we have should push to github and automagically close the pull request.

Auto-closing only works when the pushed commits match the pull request.

We give read access to github/torproject teams so that when a PR is opened people can receive an email on that repository (because they are in the team). Then I only give write access to the pusher, which is only an account we use to sync between torgit and github.

The network team has write access to some repositories, because we need it to close pull requests, and rebuild CI on Travis and Appveyor.

A few people have admin access, because we need it to modify the Travis and Appveyor CI configs.

I am going to check why this PR isn't being closed automatically. Sometimes github is slow in syncing PR, the only important thing is that once something is merged the commits can be seen on github.

The commits from github.com were squashed before pushing to torproject.org. So GitHub didn't close the pull request, because the commits did not match.

Note: See TracTickets for help on using tickets.