Opened 11 months ago

Closed 8 months ago

#28646 closed defect (fixed)

Add comments to stem.py and globals.py so people can find all the torrc options

Reported by: teor Owned by:
Priority: Medium Milestone: sbws: 1.0.x-final
Component: Core Tor/sbws Version:
Severity: Normal Keywords: fast-fix
Cc: juga, teor Actual Points:
Parent ID: Points:
Reviewer: teor Sponsor:

Description

sbws sets its own timeouts, so it should tell tor not to use adaptive timeouts:

'LearnCircuitBuildTimeout': 0,  # Disable adaptive circuit timeouts.

This was implemented in 0.3.0:
https://github.com/torproject/sbws/issues/146
https://github.com/torproject/sbws/pull/147

But reverted in 0.4.0 by mistake:
https://github.com/torproject/sbws/issues/151

Child Tickets

Change History (8)

comment:1 Changed 11 months ago by juga

I don't see that Github #151 reverted that. It was last modified in https://gitweb.torproject.org/sbws.git/commit/?id=66cb0be352251c285aa3aaa1b3a1847685071a8a, and it's still in master https://gitweb.torproject.org/sbws.git/tree/sbws/util/stem.py#n139

Edit: Github's issue

Last edited 11 months ago by juga (previous) (diff)

comment:2 Changed 11 months ago by teor

Ah, ok.

Please add a comment in globals.py and stem.py that tells people about the other half of the options.

comment:3 Changed 11 months ago by juga

Status: newneeds_review

comment:4 Changed 10 months ago by dgoulet

Reviewer: teor

comment:5 Changed 10 months ago by teor

Parent ID: #28639#28692
Status: needs_reviewneeds_information

Looks good, but I'd like to merge the two different option tables in #28692.
Then we won't need these comments.

comment:6 in reply to:  5 ; Changed 8 months ago by teor

Keywords: fast-fix added
Parent ID: #28692
Summary: Disable adaptive circuit timeoutsAdd comments to stem.py and globals.py so people can find all the torrc options

Replying to teor:

Looks good, but I'd like to merge the two different option tables in #28692.
Then we won't need these comments.

We decided not to do any refactoring in #28692.

So we still need to add comments to stem.py and globals.py so people can find all the torrc options.

This task isn't urgent, and it doesn't depend on #28692.

comment:7 in reply to:  6 Changed 8 months ago by juga

Status: needs_informationmerge_ready

Replying to teor:

So we still need to add comments to stem.py and globals.py so people can find all the torrc options.

The PR is still there.

This task isn't urgent, and it doesn't depend on #28692.

And i think it can be merge_ready, it only adds 2 comment lines.

comment:8 Changed 8 months ago by juga

Resolution: fixed
Status: merge_readyclosed

Merged.

Note: See TracTickets for help on using tickets.