Opened 5 months ago

Closed 5 weeks ago

#28656 closed defect (fixed)

Bug: src/feature/nodelist/nodelist.c:2501: compute_frac_paths_available : Non-fatal assertion !(f_exit > 0.0) failed.

Reported by: meejah Owned by:
Priority: High Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: 0.3.5.1-alpha
Severity: Normal Keywords: consider-backport-after-2019-03-19, backport-before-0359, regression, 035-rc-blocker?, 035-backport, postfreeze-ok, 040-merged-must
Cc: Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: catalyst Sponsor:

Description

I've been running Tor master recently, and saw this. This tor client (should have been) mostly idle for the past several days. It would have been used to create a bunch of custom circuits and then left alone. I see this in the logs:

Nov 28 15:15:31.000 [warn] tor_bug_occurred_(): Bug: src/feature/nodelist/nodelist.c:2501: compute_frac_paths_available: Non-fatal assertion !(f_exit > 0.0) failed. (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug: Non-fatal assertion !(f_exit > 0.0) failed in compute_frac_paths_available at src/feature/nodelist/nodelist.c:2501. Stack trace: (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(log_backtrace_impl+0x47) [0x55c0f4988067] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(tor_bug_occurred_+0xc0) [0x55c0f4983630] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(+0x11ca02) [0x55c0f48baa02] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(router_have_minimum_dir_info+0x13f) [0x55c0f48bf3bf] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(directory_info_has_arrived+0x39) [0x55c0f4807469] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(connection_dir_reached_eof+0x103a) [0x55c0f487ff0a] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(connection_handle_read+0x841) [0x55c0f48010e1] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(+0x68fde) [0x55c0f4806fde] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5(event_base_loop+0x6a0) [0x7fdcfe4455a0] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(do_main_loop+0x9d) [0x55c0f48083ad] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(tor_run_main+0x13b3) [0x55c0f47f5ae3] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(tor_main+0x3a) [0x55c0f47f2f1a] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(main+0x19) [0x55c0f47f2a99] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf1) [0x7fdcfd3712e1] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(_start+0x2a) [0x55c0f47f2aea] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 16:22:17.000 [notice] Heartbeat: Tor's uptime is 7 days 0:00 hours, with 0 circuits open. I've sent 2.66 MB and received 25.15 MB.

On the advice of #tor-dev I'm attaching the datadir.

Child Tickets

TicketStatusOwnerSummaryComponent
#29658closedNon-fatal assertion !(f_exit > 0.0) failed in compute_frac_paths_available at ../src/feature/nodelist/nodelist.c:2457Core Tor/Tor

Attachments (2)

bug-datadir.tar.gz (2.1 KB) - added by meejah 5 months ago.
datadir from the client exhibiting the bug
logs-info.txt.gz (27.8 KB) - added by meejah 8 weeks ago.
INFO level logs from a different run showing the bug

Download all attachments as: .zip

Change History (19)

Changed 5 months ago by meejah

Attachment: bug-datadir.tar.gz added

datadir from the client exhibiting the bug

comment:1 Changed 5 months ago by meejah

Some more logs:

Nov 28 09:52:28.000 [warn] tor_bug_occurred_(): Bug: src/feature/nodelist/nodelist.c:2501: compute_frac_paths_available: Non-fatal assertion !(f_exit > 0.0) failed. (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                               
Nov 28 09:52:28.000 [warn] Bug: Non-fatal assertion !(f_exit > 0.0) failed in compute_frac_paths_available at src/feature/nodelist/nodelist.c:2501. Stack trace: (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                   
Nov 28 09:52:28.000 [warn] Bug:     ./src/app/tor(log_backtrace_impl+0x47) [0x55c0f4988067] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                        
Nov 28 09:52:28.000 [warn] Bug:     ./src/app/tor(tor_bug_occurred_+0xc0) [0x55c0f4983630] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                         
Nov 28 09:52:28.000 [warn] Bug:     ./src/app/tor(+0x11ca02) [0x55c0f48baa02] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                                      
Nov 28 09:52:28.000 [warn] Bug:     ./src/app/tor(router_have_minimum_dir_info+0x13f) [0x55c0f48bf3bf] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                             
Nov 28 09:52:28.000 [warn] Bug:     ./src/app/tor(directory_info_has_arrived+0x39) [0x55c0f4807469] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                
Nov 28 09:52:28.000 [warn] Bug:     ./src/app/tor(connection_dir_reached_eof+0x103a) [0x55c0f487ff0a] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                              
Nov 28 09:52:28.000 [warn] Bug:     ./src/app/tor(connection_handle_read+0x841) [0x55c0f48010e1] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                   
Nov 28 09:52:28.000 [warn] Bug:     ./src/app/tor(+0x68fde) [0x55c0f4806fde] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                                       
Nov 28 09:52:28.000 [warn] Bug:     /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5(event_base_loop+0x6a0) [0x7fdcfe4455a0] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                            
Nov 28 09:52:28.000 [warn] Bug:     ./src/app/tor(do_main_loop+0x9d) [0x55c0f48083ad] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                              
Nov 28 09:52:28.000 [warn] Bug:     ./src/app/tor(tor_run_main+0x13b3) [0x55c0f47f5ae3] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                            
Nov 28 09:52:28.000 [warn] Bug:     ./src/app/tor(tor_main+0x3a) [0x55c0f47f2f1a] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                                  
Nov 28 09:52:28.000 [warn] Bug:     ./src/app/tor(main+0x19) [0x55c0f47f2a99] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                                      
Nov 28 09:52:28.000 [warn] Bug:     /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf1) [0x7fdcfd3712e1] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                       
Nov 28 09:52:28.000 [warn] Bug:     ./src/app/tor(_start+0x2a) [0x55c0f47f2aea] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                                    
Nov 28 10:22:17.000 [notice] Heartbeat: Tor's uptime is 6 days 18:00 hours, with 0 circuits open. I've sent 2.63 MB and received 24.48 MB.                                                                                                     
Nov 28 10:22:17.000 [notice] Average packaged cell fullness: 55.959%. TLS write overhead: 6%                                                                                                                                                   
Nov 28 11:44:28.000 [warn] tor_bug_occurred_(): Bug: src/feature/nodelist/nodelist.c:2501: compute_frac_paths_available: Non-fatal assertion !(f_exit > 0.0) failed. (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                               
Nov 28 11:44:28.000 [warn] Bug: Non-fatal assertion !(f_exit > 0.0) failed in compute_frac_paths_available at src/feature/nodelist/nodelist.c:2501. Stack trace: (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                   
Nov 28 11:44:28.000 [warn] Bug:     ./src/app/tor(log_backtrace_impl+0x47) [0x55c0f4988067] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                        
Nov 28 11:44:28.000 [warn] Bug:     ./src/app/tor(tor_bug_occurred_+0xc0) [0x55c0f4983630] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                         
Nov 28 11:44:28.000 [warn] Bug:     ./src/app/tor(+0x11ca02) [0x55c0f48baa02] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                                      
Nov 28 11:44:28.000 [warn] Bug:     ./src/app/tor(router_have_minimum_dir_info+0x13f) [0x55c0f48bf3bf] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                             
Nov 28 11:44:28.000 [warn] Bug:     ./src/app/tor(directory_info_has_arrived+0x39) [0x55c0f4807469] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                
Nov 28 11:44:28.000 [warn] Bug:     ./src/app/tor(connection_dir_reached_eof+0x103a) [0x55c0f487ff0a] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                              
Nov 28 11:44:28.000 [warn] Bug:     ./src/app/tor(connection_handle_read+0x841) [0x55c0f48010e1] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                   
Nov 28 11:44:28.000 [warn] Bug:     ./src/app/tor(+0x68fde) [0x55c0f4806fde] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                                       
Nov 28 11:44:28.000 [warn] Bug:     /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5(event_base_loop+0x6a0) [0x7fdcfe4455a0] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                            
Nov 28 11:44:28.000 [warn] Bug:     ./src/app/tor(do_main_loop+0x9d) [0x55c0f48083ad] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                              
Nov 28 11:44:28.000 [warn] Bug:     ./src/app/tor(tor_run_main+0x13b3) [0x55c0f47f5ae3] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                            
Nov 28 11:44:28.000 [warn] Bug:     ./src/app/tor(tor_main+0x3a) [0x55c0f47f2f1a] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                                  
Nov 28 11:44:28.000 [warn] Bug:     ./src/app/tor(main+0x19) [0x55c0f47f2a99] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                                      
Nov 28 11:44:28.000 [warn] Bug:     /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf1) [0x7fdcfd3712e1] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                       
Nov 28 11:44:28.000 [warn] Bug:     ./src/app/tor(_start+0x2a) [0x55c0f47f2aea] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                                    
Nov 28 13:50:29.000 [warn] tor_bug_occurred_(): Bug: src/feature/nodelist/nodelist.c:2501: compute_frac_paths_available: Non-fatal assertion !(f_exit > 0.0) failed. (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                               
Nov 28 13:50:29.000 [warn] Bug: Non-fatal assertion !(f_exit > 0.0) failed in compute_frac_paths_available at src/feature/nodelist/nodelist.c:2501. Stack trace: (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                   
Nov 28 13:50:29.000 [warn] Bug:     ./src/app/tor(log_backtrace_impl+0x47) [0x55c0f4988067] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                        
Nov 28 13:50:29.000 [warn] Bug:     ./src/app/tor(tor_bug_occurred_+0xc0) [0x55c0f4983630] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                         
Nov 28 13:50:29.000 [warn] Bug:     ./src/app/tor(+0x11ca02) [0x55c0f48baa02] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                                      
Nov 28 13:50:29.000 [warn] Bug:     ./src/app/tor(router_have_minimum_dir_info+0x13f) [0x55c0f48bf3bf] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                             
Nov 28 13:50:29.000 [warn] Bug:     ./src/app/tor(directory_info_has_arrived+0x39) [0x55c0f4807469] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                
Nov 28 13:50:29.000 [warn] Bug:     ./src/app/tor(connection_dir_reached_eof+0x103a) [0x55c0f487ff0a] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                              
Nov 28 13:50:29.000 [warn] Bug:     ./src/app/tor(connection_handle_read+0x841) [0x55c0f48010e1] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                   
Nov 28 13:50:29.000 [warn] Bug:     ./src/app/tor(+0x68fde) [0x55c0f4806fde] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                                       
Nov 28 13:50:29.000 [warn] Bug:     /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5(event_base_loop+0x6a0) [0x7fdcfe4455a0] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                            
Nov 28 13:50:29.000 [warn] Bug:     ./src/app/tor(do_main_loop+0x9d) [0x55c0f48083ad] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                              
Nov 28 13:50:29.000 [warn] Bug:     ./src/app/tor(tor_run_main+0x13b3) [0x55c0f47f5ae3] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                            
Nov 28 13:50:29.000 [warn] Bug:     ./src/app/tor(tor_main+0x3a) [0x55c0f47f2f1a] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                                  
Nov 28 13:50:29.000 [warn] Bug:     ./src/app/tor(main+0x19) [0x55c0f47f2a99] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                                      
Nov 28 13:50:29.000 [warn] Bug:     /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf1) [0x7fdcfd3712e1] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                       
Nov 28 13:50:29.000 [warn] Bug:     ./src/app/tor(_start+0x2a) [0x55c0f47f2aea] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                                                                                                    
Nov 28 15:15:31.000 [warn] tor_bug_occurred_(): Bug: src/feature/nodelist/nodelist.c:2501: compute_frac_paths_available: Non-fatal assertion !(f_exit > 0.0) failed. (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug: Non-fatal assertion !(f_exit > 0.0) failed in compute_frac_paths_available at src/feature/nodelist/nodelist.c:2501. Stack trace: (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(log_backtrace_impl+0x47) [0x55c0f4988067] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)     
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(tor_bug_occurred_+0xc0) [0x55c0f4983630] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(+0x11ca02) [0x55c0f48baa02] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                          
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(router_have_minimum_dir_info+0x13f) [0x55c0f48bf3bf] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(directory_info_has_arrived+0x39) [0x55c0f4807469] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(connection_dir_reached_eof+0x103a) [0x55c0f487ff0a] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(connection_handle_read+0x841) [0x55c0f48010e1] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(+0x68fde) [0x55c0f4806fde] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)                                
Nov 28 15:15:31.000 [warn] Bug:     /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5(event_base_loop+0x6a0) [0x7fdcfe4455a0] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(do_main_loop+0x9d) [0x55c0f48083ad] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(tor_run_main+0x13b3) [0x55c0f47f5ae3] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(tor_main+0x3a) [0x55c0f47f2f1a] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(main+0x19) [0x55c0f47f2a99] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf1) [0x7fdcfd3712e1] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 15:15:31.000 [warn] Bug:     ./src/app/tor(_start+0x2a) [0x55c0f47f2aea] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 16:22:17.000 [notice] Heartbeat: Tor's uptime is 7 days 0:00 hours, with 0 circuits open. I've sent 2.66 MB and received 25.15 MB.
Nov 28 16:22:17.000 [notice] Average packaged cell fullness: 56.026%. TLS write overhead: 6%
Nov 28 16:50:31.000 [warn] tor_bug_occurred_(): Bug: src/feature/nodelist/nodelist.c:2501: compute_frac_paths_available: Non-fatal assertion !(f_exit > 0.0) failed. (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 16:50:31.000 [warn] Bug: Non-fatal assertion !(f_exit > 0.0) failed in compute_frac_paths_available at src/feature/nodelist/nodelist.c:2501. Stack trace: (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 16:50:31.000 [warn] Bug:     ./src/app/tor(log_backtrace_impl+0x47) [0x55c0f4988067] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 16:50:31.000 [warn] Bug:     ./src/app/tor(tor_bug_occurred_+0xc0) [0x55c0f4983630] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 16:50:31.000 [warn] Bug:     ./src/app/tor(+0x11ca02) [0x55c0f48baa02] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 16:50:31.000 [warn] Bug:     ./src/app/tor(router_have_minimum_dir_info+0x13f) [0x55c0f48bf3bf] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 16:50:31.000 [warn] Bug:     ./src/app/tor(directory_info_has_arrived+0x39) [0x55c0f4807469] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 16:50:31.000 [warn] Bug:     ./src/app/tor(connection_dir_reached_eof+0x103a) [0x55c0f487ff0a] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 16:50:31.000 [warn] Bug:     ./src/app/tor(connection_handle_read+0x841) [0x55c0f48010e1] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 16:50:31.000 [warn] Bug:     ./src/app/tor(+0x68fde) [0x55c0f4806fde] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 16:50:31.000 [warn] Bug:     /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5(event_base_loop+0x6a0) [0x7fdcfe4455a0] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 16:50:31.000 [warn] Bug:     ./src/app/tor(do_main_loop+0x9d) [0x55c0f48083ad] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 16:50:31.000 [warn] Bug:     ./src/app/tor(tor_run_main+0x13b3) [0x55c0f47f5ae3] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 16:50:31.000 [warn] Bug:     ./src/app/tor(tor_main+0x3a) [0x55c0f47f2f1a] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 16:50:31.000 [warn] Bug:     ./src/app/tor(main+0x19) [0x55c0f47f2a99] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 16:50:31.000 [warn] Bug:     /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf1) [0x7fdcfd3712e1] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 16:50:31.000 [warn] Bug:     ./src/app/tor(_start+0x2a) [0x55c0f47f2aea] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 18:47:29.000 [warn] tor_bug_occurred_(): Bug: src/feature/nodelist/nodelist.c:2501: compute_frac_paths_available: Non-fatal assertion !(f_exit > 0.0) failed. (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 18:47:29.000 [warn] Bug: Non-fatal assertion !(f_exit > 0.0) failed in compute_frac_paths_available at src/feature/nodelist/nodelist.c:2501. Stack trace: (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 18:47:29.000 [warn] Bug:     ./src/app/tor(log_backtrace_impl+0x47) [0x55c0f4988067] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 18:47:29.000 [warn] Bug:     ./src/app/tor(tor_bug_occurred_+0xc0) [0x55c0f4983630] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 18:47:29.000 [warn] Bug:     ./src/app/tor(+0x11ca02) [0x55c0f48baa02] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 18:47:29.000 [warn] Bug:     ./src/app/tor(router_have_minimum_dir_info+0x13f) [0x55c0f48bf3bf] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 18:47:29.000 [warn] Bug:     ./src/app/tor(directory_info_has_arrived+0x39) [0x55c0f4807469] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 18:47:29.000 [warn] Bug:     ./src/app/tor(connection_dir_reached_eof+0x103a) [0x55c0f487ff0a] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 18:47:29.000 [warn] Bug:     ./src/app/tor(connection_handle_read+0x841) [0x55c0f48010e1] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 18:47:29.000 [warn] Bug:     ./src/app/tor(+0x68fde) [0x55c0f4806fde] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 18:47:29.000 [warn] Bug:     /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5(event_base_loop+0x6a0) [0x7fdcfe4455a0] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 18:47:29.000 [warn] Bug:     ./src/app/tor(do_main_loop+0x9d) [0x55c0f48083ad] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 18:47:29.000 [warn] Bug:     ./src/app/tor(tor_run_main+0x13b3) [0x55c0f47f5ae3] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 18:47:29.000 [warn] Bug:     ./src/app/tor(tor_main+0x3a) [0x55c0f47f2f1a] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 18:47:29.000 [warn] Bug:     ./src/app/tor(main+0x19) [0x55c0f47f2a99] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 18:47:29.000 [warn] Bug:     /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf1) [0x7fdcfd3712e1] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)
Nov 28 18:47:29.000 [warn] Bug:     ./src/app/tor(_start+0x2a) [0x55c0f47f2aea] (on Tor 0.4.0.0-alpha-dev 469f47ef8dc8b181)

comment:3 Changed 5 months ago by teor

Component: Core TorCore Tor/Tor
Keywords: regression 035-rc-must? 034-backport 035-backport added
Milestone: Tor: 0.4.0.x-final
Version: Tor: unspecifiedTor: 0.3.4.1-alpha

This was probably caused by #27236 or #27237.

comment:4 Changed 5 months ago by teor

Keywords: 035-rc-blocker? added; 035-rc-must? removed

comment:5 Changed 3 months ago by nickm

Keywords: postfreeze-ok added

Mark some tickets as postfreeze-ok, to indicate that I think they are okay to accept in 0.4.0 post-freeze. Does not indicate that they are all necessary to do postfreeze.

comment:6 Changed 2 months ago by nickm

Keywords: 040-must added

Marking tickets as 040-must based on triage with dgoulet.

comment:7 Changed 2 months ago by nickm

Priority: MediumHigh

Changed 8 weeks ago by meejah

Attachment: logs-info.txt.gz added

INFO level logs from a different run showing the bug

comment:8 Changed 8 weeks ago by meejah

I added some logs from a different run that exhibited this bug. The Tor had been idle for some time before I noticed the bug. Running version 39a104993

comment:9 Changed 7 weeks ago by teor

Actual Points: 0.1
Keywords: 034-backport removed
Points: 0.1
Status: newneeds_review
Version: Tor: 0.3.4.1-alphaTor: 0.3.5.1-alpha

There is another set of logs in #29658.

This bug was introduced in #27237 in 0.3.5.1-alpha, due to an unexpected interaction with #27236 in 0.3.4.7-rc. See the comments in the pull request for details.

We can fix it by removing the BUG() warning:
https://github.com/torproject/tor/pull/758

(Note that !(f_exit > 0.0) is the same as (f_exit == 0.0), because f_exit can never be negative.)

Exit: fix ticket number

Last edited 7 weeks ago by teor (previous) (diff)

comment:10 in reply to:  9 Changed 7 weeks ago by teor

Replying to teor:

(Note that !(f_exit > 0.0) is the same as (f_exit == 0.0), because f_exit can never be negative.)

Ah, but some compilers warn on float ==.
I pushed a fixup.

comment:11 Changed 6 weeks ago by asn

Reviewer: catalyst

comment:12 Changed 6 weeks ago by catalyst

Status: needs_reviewmerge_ready

Looks good to me! Coverage went down by a couple of lines, possibly because the removed BUG() was previously marking unreachable code.

comment:13 Changed 6 weeks ago by nickm

Milestone: Tor: 0.4.0.x-finalTor: 0.3.5.x-final

Okay, I've squashed the branch as bug28656_035_squashed, and made a new PR as https://github.com/torproject/tor/pull/798 . Merging to 0.4.0 and forward. Marking for possible backport.

comment:14 in reply to:  13 ; Changed 6 weeks ago by catalyst

Replying to nickm:

Okay, I've squashed the branch as bug28656_035_squashed, and made a new PR as https://github.com/torproject/tor/pull/798 . Merging to 0.4.0 and forward. Marking for possible backport.

Backport pull request looks good. I have no strong opinions either way about backporting it to 0.3.5. Has anyone reported it triggering on 0.3.5?

comment:15 in reply to:  14 Changed 6 weeks ago by teor

Keywords: consider-backport-after-2019-03-19 backport-before-0359 added

Replying to catalyst:

Replying to nickm:

Okay, I've squashed the branch as bug28656_035_squashed, and made a new PR as https://github.com/torproject/tor/pull/798 . Merging to 0.4.0 and forward. Marking for possible backport.

Backport pull request looks good. I have no strong opinions either way about backporting it to 0.3.5. Has anyone reported it triggering on 0.3.5?

Yes, #29658 is a report on 0.3.5.8.

And it was introduced in 0.3.5.1-alpha, so we don't need to backport any further:

Replying to teor:

This bug was introduced in #27237 in 0.3.5.1-alpha, due to an unexpected interaction with #27236 in 0.3.4.7-rc. See the comments in the pull request for details.

(I haven't seen any reports earlier than 0.3.5.)

Here's my backport assessment:

This patch modifies application code by removing a BUG() warning and simplifying a condition into an equivalent condition. It affects 1 code line and a few comment lines.

It is a low risk, obviously beneficial change. We have two (or three) bug reports on 0.3.5.8, 0.4.0.0-alpha-dev, and 0.4.0.1-alpha-dev.

I'd like to backport it after a few working days in nightly, and before the next 0.3.5 release.

comment:16 Changed 5 weeks ago by teor

Keywords: 040-merged-must added; 040-must removed

This ticket has been merged to 0.4.0.

comment:17 Changed 5 weeks ago by teor

Resolution: fixed
Status: merge_readyclosed

Merged to 0.3.5 and merged forward.
Merged #29740 and #28656 together.

Note: See TracTickets for help on using tickets.