Opened 11 months ago

Last modified 4 months ago

#28673 new enhancement

Make private_nets aware of Carrier Grade NAT (RFC 6598)

Reported by: neel Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In #28525, we make tor_addr_is_internal_() aware of RFC 6598. teor has said that we need a consensus method to do this in private_nets:

It is important
 *  that all authorities agree on that list when creating summaries, so don't
 *  just change this without a proper migration plan and a proposal and stuff.

Child Tickets

Change History (4)

comment:1 Changed 11 months ago by teor

Milestone: Tor: unspecified
Type: defectenhancement

comment:2 Changed 4 months ago by cypherpunks

please stop RFC 6598 addresses also by reporting as "your ip" #30084 this will not work in a descriptor anyway

comment:3 in reply to:  2 Changed 4 months ago by teor

Replying to cypherpunks:

please stop RFC 6598 addresses also by reporting as "your ip" #30084 this will not work in a descriptor anyway

I think we did that in #28525. It should be in the latest 0.4.1 alpha and th3 latest 0.4.0.

comment:4 Changed 4 months ago by cypherpunks

my comment offtopic

i have quick look over it, seems tor_addr_is_internal_ https://github.com/neelchauhan/tor/blob/4aa3490fc9bec0a71bb25e3590cd44c2eec02118/src/lib/net/address.c#L246 handles it here already. can't see change for "reporting as "your ip"" but it makes it aware of the "new" 100.64/10.

so this is not this issue.

Note: See TracTickets for help on using tickets.