Opened 3 months ago

Closed 3 months ago

#28696 closed defect (fixed)

Changing paths to Gradle dependencies are included in build

Reported by: gk Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, tbb-rbm, TorBrowserTeam201812R
Cc: boklm, sisbell Actual Points:
Parent ID: #25164 Points:
Reviewer: Sponsor:


To use the downloaded Gradle dependencies for our Android Tor Browser we do

  export GRADLE_MAVEN_REPOSITORIES="file://$rootdir/[% c('input_files_by_name/gradle-dependencies') %]"

$rootdir, however, results in including a changing path into the final .apk as it gets embedded into chrome/toolkit/content/global/buildconfig.html. The result is something like "file:///var/tmp/tmp.Flce6AvlTV/gradle-dependencies-3" which breaks our reproducible builds.

Child Tickets

Change History (7)

comment:1 Changed 3 months ago by boklm

I think we can fix that by doing a mv $rootdir/[% c('input_files_by_name/gradle-dependencies') %] /var/tmp/gradle-dependencies (or other fixed path in /var/tmp).

comment:2 Changed 3 months ago by gk

Yeah, sounds good.

comment:3 Changed 3 months ago by gk

Keywords: tbb-rbm added

comment:4 Changed 3 months ago by sisbell

Status: newneeds_review

Fixed in android-1203

  • Uses a hard-coded grade-dependencies location (as suggested by boklm)

comment:5 Changed 3 months ago by boklm

Status: needs_reviewneeds_revision

I think setting setting GRADLE_MAVEN_REPOSITORIES and moving gradle-dependencies to /var/tmp/gradle-dependencies should be done in the same place, instead of setting GRADLE_MAVEN_REPOSITORIES at the top, and much later moving the files to that directory.

Maybe we don't need to set GRADLE_MAVEN_REPOSITORIES at the top and we can do it in the same second IF c("var/android") block (and then we can remove the first one).

comment:6 Changed 3 months ago by sisbell

Status: needs_revisionneeds_review

Changes (android-1205)

  • Moved GRADLE_MAVEN_REPOSITORIES into the second IF block and removed first.

comment:7 Changed 3 months ago by gk

Keywords: TorBrowserTeam201812R added; TorBrowserTeam201812 removed
Resolution: fixed
Status: needs_reviewclosed

Looks good and merged to master (commit 9ec8d7fb09a2069ef7c79d81547040ce6661ab3b).

Note: See TracTickets for help on using tickets.