Opened 7 months ago

Closed 5 months ago

#28715 closed defect (fixed)

Some torrc options don't have an argument

Reported by: teor Owned by:
Priority: Medium Milestone: sbws: 1.0.x-final
Component: Core Tor/sbws Version:
Severity: Normal Keywords:
Cc: juga, teor Actual Points:
Parent ID: Points:
Reviewer: nickm Sponsor:

Description

In stem.py, sbws requires extra torrc options to have a keyword and an argument. But an empty list is a valid value for some torrc options.

For example:

LongLivedPorts
ExitPolicy

Tentatively assigning to sbws 1.0, because this kind of bug could really annoy operators.

Child Tickets

Change History (5)

comment:1 Changed 6 months ago by juga

Status: newneeds_review

https://github.com/torproject/sbws/pull/309
I based the branch on #28738 which refactor that part of the code in a function, to be able to test it.
If #28738 change, this branch should be rebased to it.

comment:2 Changed 6 months ago by dgoulet

Reviewer: nickm

comment:3 Changed 6 months ago by nickm

Status: needs_reviewmerge_ready

LGTM, but see comments on #28738.

comment:4 Changed 6 months ago by juga

Rebased to current #28738 in https://github.com/torproject/sbws/pull/318.
Will wait until #28738 is merged to merge this.

comment:5 Changed 5 months ago by juga

Resolution: fixed
Status: merge_readyclosed

Merged.

Note: See TracTickets for help on using tickets.