Opened 7 weeks ago

Closed 2 weeks ago

#28724 closed defect (fixed)

sbws doesn't actually read config files given as an argument

Reported by: pastly Owned by: juga
Priority: High Milestone: sbws: 1.0.x-final
Component: Core Tor/sbws Version:
Severity: Major Keywords:
Cc: juga, teor Actual Points:
Parent ID: Points:
Reviewer: juga Sponsor:

Description

Child Tickets

Change History (7)

comment:1 Changed 7 weeks ago by pastly

Status: newneeds_review

https://github.com/torproject/sbws/pull/306

DIdn't add to changelog because IDR if I'm supposed to.

comment:2 Changed 7 weeks ago by juga

Status: needs_reviewneeds_revision

Thanks, left comments in the PR.

comment:3 Changed 7 weeks ago by juga

Reviewer: juga

comment:4 Changed 2 weeks ago by juga

pastly, do you have time to continue with this during this week or should i fix it?

comment:5 Changed 2 weeks ago by juga

Owner: set to juga
Status: needs_revisionassigned

This blocks #28933.

comment:6 Changed 2 weeks ago by juga

Status: assignedmerge_ready

Created a new PR since i can't accept my own suggestions: https://github.com/torproject/sbws/pull/326.
It's also based from current master, since tor from deb.torproject.org has been removed for Trusty some hour agao. and none of the tests would pass.
Since this was already reviewed, don't think there's need to put again in needs_review.

comment:7 Changed 2 weeks ago by juga

Resolution: fixed
Status: merge_readyclosed

Merged

Note: See TracTickets for help on using tickets.