Opened 8 months ago

Last modified 11 days ago

#28745 needs_review defect

THE Torbutton clean-up

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-torbutton TorBrowserTeam201907R
Cc: igt0 Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

That is the parent ticket for all things Torbutton clean-up, now that we included it into tor-browser. It's not clear yet how we'll be restructuring it but it's clear that a lot of old cruft has to go. This will be done in child tickets.

Child Tickets

TicketStatusOwnerSummaryComponent
#28746newtbb-teamRemove torbutton_update_isolation_prefs() and torbutton_update_fingerprinting_prefs()Applications/Tor Browser
#28747closedtbb-teamRemove old NoScript related code (needed for dealing with the XPCOM version)Applications/Tor Browser
#28894closedtbb-teamRemove Torbutton parts of fix for #20244Applications/Tor Browser
#30850newtbb-teamMove not UI-related torbutton.js code to XPCOM component/serviceApplications/Tor Browser
#30851newtbb-teamMove torbutton default prefs to 000-tor-browser.jsApplications/Tor Browser
#30888newtbb-teamMinimize torbutton globals exposed in browser windowApplications/Tor Browser

Change History (6)

comment:1 Changed 8 months ago by gk

Cc: igt0 added

comment:2 Changed 6 weeks ago by acat

There is some work in https://github.com/acatarineu/torbutton/compare/10760...10760+1. Adding it here instead of #10760, and assuming this is a next step. Commit for #30851 needs tor-browser changes from https://github.com/acatarineu/tor-browser/commit/30851.

comment:3 Changed 6 weeks ago by acat

Status: newneeds_review

comment:4 Changed 5 weeks ago by acat

Status: needs_reviewnew

I think it's better to wait until #10760 changes are reviewed and accepted, because the changes here will depend on that. So removing the review flag until then.

comment:5 Changed 12 days ago by acat

Keywords: TorBrowserTeam201907R added
Status: newneeds_review

Some changes for review here: https://github.com/acatarineu/torbutton/commits/28745 (starting from 6023e0875c8085a58e6269801113a2a4600cb6d3, which is the last commit from #10760 patch). Corresponding tor-browser changes here: https://github.com/acatarineu/tor-browser/commits/28745 (last 4 commits).

Some comments:

Remove cookie-jar-selector component

  • For browser.privatebrowsing.autostart = true, cookie-jar-selector does nothing currently, so for new identity we just clearCookies().
  • For browser.privatebrowsing.autostart = false, some cookies json files are stored in the browser profile folder, which we clear on startup in the patch.

Bug 30851: Move default preferences to 000-tor-browser.js

  • This has a corresponding patch in tor-browser.

Bug 30888: move torbutton_util.js to modules/utils.js

  • This also has a corresponding patch in tor-browser, to stop including torbutton_util.js in browser.xul.

Make torbutton_open_network_settings global

  • This will have to be called somewhere in UI at some point, for now we just expose it.

Refactor code to always use tor-control-port.js

  • Trying to use a single implementation of tor controller. Perhaps next step would be to do the same with tor-launcher.
  • The code had to be adapted a bit, since tor-control-port.js is async while previous impl. was sync.

Remove versioncheck from torbutton.js

  • I'm assuming we don't need this, with the browser updater and having removed the blinking notification in torbutton UI. But perhaps we still want as telemetry, not sure.

comment:6 Changed 11 days ago by cypherpunks

Refactor code to always use tor-control-port.js

It's a rewriting, not only refactoring. Should we do it inside the general clean-up?

Note: See TracTickets for help on using tickets.