Gradle sometimes downloads tor-android-binary resources during build (or the build is failing)

I saw a failing builds in comment:42:ticket:27977 and later on complaining about missing tor-android-binary resources (*.pom and *.aar). Today I saw a build where Gradle is even downloading both files during build. I double-checked and they are available in gradle-dependecies-3 which we use during build, which is pretty concerning.

We should figure our what is going on here.

added TBA-a3 TorBrowserTeam201812R component::applications/tor browser owner::tbb-team priority::very high resolution::fixed severity::normal sponsor::8 status::closed tbb-mobile tbb-rbm type::defect labels

Trac:
Cc: N/A to sisbell

Gradle offline is flagged so it shouldn't download anything (although there can always be a bug in gradle). It could be that the files are not actually downloading even though the logs say it is attempting download. Did the build say it was downloading and then pass the build. Or did it say it was downloading and then fail the build?

Replying to sisbell:

Gradle offline is flagged so it shouldn't download anything (although there can always be a bug in gradle). It could be that the files are not actually downloading even though the logs say it is attempting download. Did the build say it was downloading and then pass the build. Or did it say it was downloading and then fail the build?

It says it was downloading

26:02.41 :geckoview:compileOfficialWithGeckoBinariesNoMinApiReleaseJavaWithJavac
26:02.43 Download https://raw.githubusercontent.com/guardianproject/gpmaven/master/org/torproject/tor-android-binary/0.3.4.9/tor-android-binary-0.3.4.9.pom
26:04.40 Download https://raw.githubusercontent.com/guardianproject/gpmaven/master/org/torproject/tor-android-binary/0.3.4.9/tor-android-binary-0.3.4.9.aar
26:04.91 :app:generateOfficialWithoutGeckoBinariesNoMinApiPhotonDebugAndroidTestResValues

and then the build passed. My guess is that in the rare cases I saw the build failures this resulted in the download failing for some reason. And later on the missing dependencies were not available.

The big question is why it is downloading those things and just those two even though we bundled everything.

Setting tag for third Tor Browser for Android alpha milestone.

Trac:
Keywords: N/A deleted, TBA-a3 added

Adding Sponsor8 tag.

Trac:
Sponsor: N/A to Sponsor8

We don't see the tor-android-binary download during the orbot build but we see it in the firefox build. The reason is that orbot is moving the artifact to the correct gradle cache location during its build. Firefox build is not. I'll get in a fix shortly.

I've got the fix ready but the current build is giving me an error in the firefox-locale-bundle. It looks like a perl module isn't installed.

Can't locate JSON.pm in @INC (you may need to install the JSON module)
....
BEGIN failed--compilation aborted at /home/shane/github/tor-browser-4/projects/firefox-locale-bundle/get_hg_hash line 4.

Replying to sisbell:

I've got the fix ready but the current build is giving me an error in the firefox-locale-bundle. It looks like a perl module isn't installed.

{{{ Can't locate JSON.pm in @INC (you may need to install the JSON module) .... BEGIN failed--compilation aborted at /home/shane/github/tor-browser-4/projects/firefox-locale-bundle/get_hg_hash line 4. }}}

Yes, you need to install that perl module on your build machine, see the README and the commit message of commit 56ce89fe1a99c304b7292a7087ae8d0ad2412273.

Changes (android-1216)

• Copy the tor-android-binary files to correct location in the gradle repo (firefox project). This fixes the download issue.

Trac:
Status: new to needs_review

I've not tested it yet but some small nits while reading through the changes:

1. s/assumes artifact package/assumes the artifact package/
2. s/artifacts to correct location/artifacts to the correct location./

Trac:
Status: needs_review to needs_revision

The fix looks good and works for me. Please address the nits in comment:11 and we can get this landed, thanks!

Changes (android-1219)

• Changes as suggested in !comment:11

Trac:
Status: needs_revision to needs_review

Cherry-picked to master (9b0b7b5159e670e04d5705350f33f8b2aa056634) (and I shortened the subject line of your commit message a bit).

Trac:
Status: needs_review to closed
Keywords: TorBrowserTeam201812 deleted, TorBrowserTeam201812R added
Resolution: N/A to fixed

closed

mentioned in issue #28753 (moved)

moved to tpo/applications/tor-browser#28752 (closed)

mentioned in issue tpo/applications/tor-browser#28753 (closed)