Opened 23 months ago

Last modified 5 months ago

#28754 new defect

make testbuild-android-armv7 stalls during sha256sum step

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, gitlab-tb-tor-browser-build
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Suppose you don't have a testbuild directory containing any already built bundles. Now, start a build with make testbuild-android-armv7 to get an .apk. The result is a stalled build in the release project.

The reason for that is that

sha256sum $(ls -1 *.exe *.tar.xz *.dmg *.mar *.zip *.tar.gz | grep -v '\.incremental\.mar$' | sort) > sha256sums-unsigned-build.txt

evaluates to

sha256sum > sha256sums-unsigned-build.txt

which waits for input. We have not been hitting that so far as both in the alpha and the nightly case other bundles in the directory are available. And for the mobile case #25164 is about to fix this as well. However, we might want to be a bit more conservative and only execute sha256sum if we actually have an argument to pass. Otherwise this can lead to surprising results (like in this case).

Child Tickets

Change History (1)

comment:1 Changed 5 months ago by gk

Keywords: gitlab-tb-tor-browser-build added

Add magic gitlab keyword.

Note: See TracTickets for help on using tickets.