Opened 10 months ago

Closed 9 months ago

#28757 closed defect (implemented)

Remove deprecated ControlPort commands from GETINFO info/names listing

Reported by: wagon Owned by: rl1987
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords: tor-control, tor-spec, easy
Cc: Actual Points:
Parent ID: Points:
Reviewer: catalyst Sponsor:

Description

If GETINFO commands status/version/num-concurring and status/version/num-versioning are used in Nyx or tor-prompt, Tor writes to its log file:

[warn] status/version/num-concurring is deprecated; it no longer gives useful information
[warn] status/version/num-versioning is deprecated; it no longer gives useful information

These commands should be removed from interpreter's /help GETINFO listing. They are deprecated according to control-spec.txt:

"status/version/num-concurring"
"status/version/num-versioning"
  These options are deprecated; they no longer give useful information.

since 0.2.0.30 (more than 10 years):

o Newly deprecated features:

  • The status/version/num-versioning and status/version/num-concurring GETINFO controller options are no longer useful in the v3 directory protocol: treat them as deprecated, and warn when they're used.

Probably, there are also other deprecated commands in /help listing. They should be removed too.

P.S. Initially it was reported in this comment. teor recommended to create separate ticket.

Child Tickets

Change History (15)

comment:1 Changed 10 months ago by atagar

Resolution: worksforme
Status: assignedclosed

Hi wagon. Nyx (and by extension Stem's) '/help GETINFO' listing comes from tor itself through its 'GETINFO info/names' command. This means that the help output will list all GETINFO commands tor itself advertises (including new features in the future). When your tor instance no longer supports that command it will cease to be listed.

comment:2 Changed 10 months ago by wagon

Component: Core Tor/NyxCore Tor/Tor
Keywords: tor-control tor-spec added
Resolution: worksforme
Status: closedreopened
Summary: Remove deprecated ControlPort commands from controller interpreter's /helpRemove deprecated ControlPort commands from GETINFO info/names listing
Version: Tor: 0.3.4.9
Last edited 10 months ago by wagon (previous) (diff)

comment:3 Changed 10 months ago by wagon

This means that the help output will list all GETINFO commands tor itself advertises (including new features in the future)

Good, I didn't know about it. It means it is not Nyx, but core Tor's bug. I reopen the ticket and ascribe it to Tor team. Maybe teor will take care about this ticket.

comment:4 Changed 10 months ago by teor

Keywords: easy added
Milestone: Tor: unspecified

comment:5 Changed 9 months ago by rl1987

Owner: changed from atagar to rl1987
Status: reopenedaccepted

comment:7 Changed 9 months ago by wagon

Thanks, rl1987! It looks good.

comment:8 Changed 9 months ago by nickm

(We should ask the various controller maintainers whether this will break anything on their side.)

comment:9 Changed 9 months ago by teor

Milestone: Tor: unspecifiedTor: 0.4.0.x-final
Version: Tor: 0.3.4.9Tor: unspecified

comment:10 Changed 9 months ago by dgoulet

Reviewer: teor

comment:11 Changed 9 months ago by dgoulet

Reviewer: teorcatalyst

comment:12 Changed 9 months ago by catalyst

Status: needs_reviewmerge_ready

Both the spec changes and the code changes look good to me. Maybe the spec change should say which version we removed them in, and maybe also which version they stopped giving useful information. Then again maybe this has been deprecated long enough that it's not important to mention that.

comment:13 Changed 9 months ago by nickm

Before I merge this, I'd like an ack from atagar that nothing in Stem will break if we remove the deprecated stuff from GETINFO info/names.

comment:14 Changed 9 months ago by atagar

Hi Nick, looks fine to me.

comment:15 Changed 9 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Okay, merged to 0.4.0.

Note: See TracTickets for help on using tickets.