OpenSSL Build for Android

added TorBrowserTeam202003R component::applications/tor browser owner::sisbell parent::28704 points::0.5 priority::medium resolution::fixed reviewer::boklm reviewer::sysrqb severity::normal status::closed tbb-mobile tbb-parity tbb-rbm type::defect labels

Initial commit for review (android-1207)

Trac:
Status: new to needs_review

Trac:
Keywords: TorBrowserTeam201812 deleted, TorBrowserTeam201812R added

Three things we should think about here:

1. The OpenSSL output is not build reproducibly. The .a creation is not deterministic as it seems to contain timestamps, see:

0007ce70: 0000 0000 0000 0000 0000 6001 0000 0b00  ..........`.....
 0007ce80: 0000 0000 0000 0000 0000 0100 0000 0000  ................
 0007ce90: 0000 7373 6c5f 7574 7374 2e6f 2f20 2020  ..ssl_utst.o/   
-0007cea0: 2020 3135 3434 3532 3132 3032 2020 3130    1544521202  10
+0007cea0: 2020 3135 3434 3532 3035 3032 2020 3130    1544520502  10
 0007ceb0: 3030 2020 3130 3030 2020 3130 3036 3434  00  1000  100644
 0007cec0: 2020 3736 3420 2020 2020 2020 600a 7f45    764       `..E
 0007ced0: 4c46 0101 0100 0000 0000 0000 0000 0100  LF..............

I wonder why that is an issue here. Maybe the cross-toolchain for Android does not have something like -Wl,--no-insert-timestamp?

2. Do we really need all the exported env variables in the build script? The build seemed to work for me e.g. without declaring RANLIB?

3. The comment in the config file should we wrapped so that we have it on two lines instead of one.

Trac:
Keywords: TorBrowserTeam201812R deleted, TorBrowserTeam201812 added
Status: needs_review to needs_revision

tbb-parity items.

Trac:
Keywords: N/A deleted, tbb-parity added

https://wiki.openssl.org/index.php/Android

Recheck enable-ec_nistp_64_gcc_128.

Trac:
Points: N/A to 0.5

This is a really old commit from Dec 7th (branch 1219) so I'll need to update and test with what we have now but the following was working at the time.

https://github.com/sisbell/tor-browser-build/commit/c00bf3abba168b3462b2f93ed95e2ad1b530ec87

Of course the same issues are still a problem, but just including the commit for reference.

FYI, I tried building with enable-ec_nistp_64_gcc_128 using Android NDK r20, which only has clang and it failed. It seems that clang lacks some feature needed to build with enable-ec_nistp_64_gcc_128.

Trac:
Owner: tbb-team to sisbell
Status: needs_revision to assigned
Keywords: TorBrowserTeam201812 deleted, TorBrowserTeam201912 added

Trac:
Cc: sisbell, gk to sisbell, gk, tbb-team

Useful reference for this issue

https://github.com/openssl/openssl/blob/master/NOTES.ANDROID

I verified it builds on all 4 targets. I have not verified reproducibility.

https://github.com/sisbell/tor-browser-build/commit/a4d6fdcdee0217197216b3d82705d91f0ebc6190

Trac:
Status: assigned to needs_review
Keywords: TorBrowserTeam201912 deleted, TorBrowserTeam201912R added

Trac:
Reviewer: N/A to sysrqb, boklm

Trac:
Keywords: TorBrowserTeam201912R deleted, TorBrowserTeam202001R added

Trac:
Keywords: TorBrowserTeam202001R deleted, TorBrowserTeam202001 added
Status: needs_review to needs_revision

Moving tickets to February

Trac:
Keywords: TorBrowserTeam202001 deleted, TorBrowserTeam202002 added

This is based on commit b06af71cf1aed690da281e4eb2f89294d48dcb15 from ticket:28704#comment:23.

-make
-make DESTDIR="$distdir" install
+ make
+ make DESTDIR="$distdir" install

nit: Please delete the new space introduced at the beginning of the line.

Removed the white space at beginning of lines and removed libtinfo dependency since this is now included in rbm.conf

https://github.com/sisbell/tor-browser-build/commits/bug-28764

Trac:
Status: needs_revision to needs_review

Trac:
Keywords: TorBrowserTeam202002 deleted, TorBrowserTeam202002R added

Trac:
Keywords: TorBrowserTeam202002R deleted, TorBrowserTeam202003R added

Replying to sisbell:

Removed the white space at beginning of lines and removed libtinfo dependency since this is now included in rbm.conf

https://github.com/sisbell/tor-browser-build/commits/bug-28764

This looks good to me. I cherry-picked the patch to master as commit b380d694e605e46500e411c792602e08cdbb6fb2.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

changed time estimate to 4h

mentioned in issue #32200 (moved)

moved to tpo/applications/tor-browser#28764 (closed)

mentioned in issue tpo/applications/tor-browser-build#32200