#28771 closed defect (fixed)

Does the build still require libfile-slurp-perl?

Reported by: dcf Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201812R
Cc: boklm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

a6d54303a removed libfile-slurp-perl from README. But 43c9452946 added projects/firefox-locale-bundle/get_hg_hash which requires it. This is the error I get in logs/firefox-locale-bundle-android-armv7.log:

pulling from https://hg.mozilla.org/l10n-central/ar
searching for changes
no changes found
Can't locate File/Slurp.pm in @INC (you may need to install the File::Slurp module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at /home/user/tor-browser-build/projects/firefox-locale-bundle/get_hg_hash line 3.
BEGIN failed--compilation aborted at /home/user/tor-browser-build/projects/firefox-locale-bundle/get_hg_hash line 3.

Child Tickets

Attachments (1)

0001-Port-get_hg_hash-to-Path-Tiny-and-note-JSON-dependen.patch (1.8 KB) - added by dcf 12 months ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 12 months ago by dcf

Status: newneeds_review

Here's a small patch porting get_hg_hash from File::Slurp to Path::Tiny. I followed the model of 8b6831b36b. I found out that the script also has a dependency on the JSON module, so I noted that in README.

It seems that tools/clean-old and tools/dmg2mar still require File::Slurp.

comment:2 Changed 12 months ago by gk

Cc: boklm added
Keywords: tbb-rbm TorBrowserTeam201812R added

comment:3 Changed 12 months ago by boklm

Resolution: fixed
Status: needs_reviewclosed

The patch looks good to me. I merged it to master as commit 56ce89fe1a99c304b7292a7087ae8d0ad2412273. Thanks!

I also opened #28782 for doing the same in tools/clean-old and tools/dmg2mar.

Note: See TracTickets for help on using tickets.