Opened 10 months ago

Last modified 5 months ago

#28774 needs_revision defect

Stop the integration tests http server when the tests end

Reported by: juga Owned by: juga
Priority: Medium Milestone: sbws: unspecified
Component: Core Tor/sbws Version:
Severity: Normal Keywords: no-changes-version, tests, sbws-11x-final-removed-20190312, reviewer-was-teor-20190422
Cc: juga, teor Actual Points:
Parent ID: #29953 Points:
Reviewer: Sponsor:

Description

The integration tests launch an HTTP server (tox.ini), but it is not stop after tests finish.
This affect the developer running the integration tests, not the operator.

Child Tickets

Change History (13)

comment:1 Changed 9 months ago by juga

Status: newneeds_review

comment:2 Changed 9 months ago by dgoulet

Reviewer: teor

comment:3 Changed 8 months ago by juga

Owner: set to juga
Status: needs_reviewassigned

Because tickets in milestone 1.0 should be reviewed first, leave tickets in milestone 1.1 assigned until 1.0 is released.

comment:4 Changed 7 months ago by juga

Status: assignedneeds_review

comment:5 Changed 7 months ago by teor

Status: needs_reviewneeds_revision

This pull request conflicts with master, and the CI has errored.
I don't know how to fix these issues.

comment:6 in reply to:  5 Changed 7 months ago by juga

Status: needs_revisionneeds_review

Replying to teor:

This pull request conflicts with master, and the CI has errored.

Rebased to master in https://github.com/torproject/sbws/pull/343.
The CI error was due Travis failing again to obtain gpg key. The commit that fixed that wasn't in that branch yet.

comment:7 Changed 7 months ago by teor

Status: needs_reviewmerge_ready

Seems fine to me.

Do you expect this test to work on non-Linux systems:
"The equivalent command on BSD operating systems is fstat(1)"
https://en.wikipedia.org/wiki/Fuser_(Unix)

comment:8 Changed 7 months ago by teor

Status: merge_readyneeds_revision

comment:9 Changed 6 months ago by juga

Keywords: no-changes-version added

Add keyword to help planify releases/milestones.
Tickets that doesn't imply a change of version are tickets which do not affect the code (docs, tests) and some time of refactors.

comment:10 Changed 6 months ago by juga

Keywords: tests added

Add keyword

comment:11 Changed 6 months ago by juga

Keywords: sbws-11x-final-removed-20190312 added
Milestone: sbws: 1.1.x-finalsbws: unspecified

Remove tickets from 11x-final that can be implemented next month

comment:12 Changed 6 months ago by juga

Parent ID: #29953

Assign parent to easy, no-changes-version tickets to better track them

comment:13 Changed 5 months ago by teor

Keywords: reviewer-was-teor-20190422 added
Reviewer: teor

If these tickets go back in to needs_review, and I am on leave, they will need another reviewer.

Note: See TracTickets for help on using tickets.