Opened 12 months ago

Last modified 7 months ago

#28777 new defect

Split circuitpadding.c code into multiple modules

Reported by: asn Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: wtf-pad, tor-relay, tor-cell, padding, refactor, technical-debt
Cc: nickm Actual Points:
Parent ID: Points: 3
Reviewer: Sponsor: Sponsor2

Description

Circuitpadding.c is pretty huge and we can split it into further modules.

A possible division could be:

  • circuit padding code that deals with network/circuits etc.
  • circuit padding code that deals with padding negotiation
  • circuit padding histogram-related code
  • circuit padding distribution-related code
  • circuit padding machine maintainance code

Child Tickets

Change History (10)

comment:1 Changed 12 months ago by asn

Keywords: refactor tech-debt added

comment:2 Changed 12 months ago by asn

Keywords: technical-debt added; tech-debt removed

comment:3 Changed 11 months ago by asn

Furthermore we can move some of the private structures in circuitpadding.h to a circuitpadding_st.h header file as suggested in https://github.com/torproject/tor/pull/624#discussion_r246444470

comment:4 Changed 11 months ago by mikeperry

Keywords: 041-proposed added

comment:5 Changed 11 months ago by mikeperry

Points: 3

comment:6 Changed 11 months ago by nickm

Sponsor: Sponsor2

comment:7 Changed 10 months ago by nickm

Parent ID: #28637#28631

Reparent children of #28637 into #28631

comment:8 Changed 9 months ago by mikeperry

Keywords: 041-proposed removed

Take some wtf-pad stuff out of 041-proposed

comment:9 Changed 7 months ago by mikeperry

Parent ID: #28631

comment:10 Changed 7 months ago by mikeperry

Priority: MediumLow

We did some of this separation in #28634 and with the probdist stuff Riastradh did. I don't think the rest of it is that terribly crucial..

Note: See TracTickets for help on using tickets.