Opened 4 months ago

Closed 4 months ago

Last modified 3 weeks ago

#28779 closed defect (fixed)

Remove double function declarations in circuitpadding.c/test_circuitpadding.c

Reported by: asn Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: wtf-pad, tor-relay, tor-cell, padding, technical-debt, refactor, easy
Cc: nickm Actual Points:
Parent ID: #28637 Points:
Reviewer: asn Sponsor: Sponsor2

Description

We can use the STATIC macro to avoid defining every function twice.
We can also rearrange the circuitpadding.c functions so that we don't need to define them on top of the .c file.

Child Tickets

Change History (4)

comment:1 Changed 4 months ago by mikeperry

Status: newneeds_review

Oh btw I did this on Friday. We actually hit a clang-specific test bug due to differing function return types, so I removed them all.

I think this is done. Leaving in needs_review for asn.

comment:2 Changed 4 months ago by mikeperry

Reviewer: asn

comment:3 Changed 4 months ago by asn

Resolution: fixed
Status: needs_reviewclosed

LGTM! Closing this.

comment:4 Changed 3 weeks ago by teor

Sponsor: Sponsor2

Move all WTF-PAD tickets that do not have a sponsor into sponsor2.

Note: See TracTickets for help on using tickets.