Opened 10 months ago

Closed 8 months ago

#28788 closed defect (fixed)

Document configuration verify option and disable urllib3

Reported by: juga Owned by:
Priority: Medium Milestone: sbws: 1.0.x-final
Component: Core Tor/sbws Version: sbws: 1.0.2
Severity: Normal Keywords:
Cc: juga, teor Actual Points:
Parent ID: Points:
Reviewer: mikeperry Sponsor:

Description

In #28647 we say that it's ok that the destination certificate is self-signed.
There was no any documentation about how sbws could accept self-signed certificates and the default was hard-coded.
There're different ways to validate certificates with Python requests (http://docs.python-requests.org/en/master/user/advanced/#ssl-cert-verification), but the only one implemented is to don't verify the certificate.
The simpler way to accept self-signed certificates is to don't verify it.
When using this option, there're urllib3 warnings that should be disabled.

Child Tickets

Change History (4)

comment:1 Changed 10 months ago by juga

Status: assignedneeds_review

comment:2 Changed 10 months ago by dgoulet

Reviewer: mikeperry

comment:3 Changed 8 months ago by mikeperry

Status: needs_reviewmerge_ready

This seems OK.

comment:4 Changed 8 months ago by juga

Resolution: fixed
Status: merge_readyclosed

Thanks, merged!

Note: See TracTickets for help on using tickets.