Opened 8 months ago

Closed 2 weeks ago

#28797 closed enhancement (fixed)

Set up CI on the fallback script with a small number of relays

Reported by: teor Owned by:
Priority: Medium Milestone:
Component: Core Tor/Fallback Scripts Version:
Severity: Normal Keywords: fallback, fallback-ci
Cc: teor, nickm Actual Points: 0.5
Parent ID: #28793 Points: 0.5
Reviewer: nickm Sponsor:

Description

We should test the list generation and check_existing modes, with a few relays (10?).

Child Tickets

Change History (12)

comment:1 Changed 8 months ago by teor

Type: defectenhancement

comment:2 Changed 7 months ago by teor

Milestone: Tor: unspecified

After #27914, fallback-scripts is its own repository. Fallback changes are no longer tied to Tor releases.

comment:3 Changed 2 months ago by teor

We can copy the chutney or stem Travis CI, and use it as a starting point.

comment:4 Changed 8 weeks ago by teor

Parent ID: #28793

I don't think we'll do this any time soon.

comment:5 Changed 7 weeks ago by teor

The command:

$ TOR_FB_MAX_FALLBACK_COUNT=10 ./updateFallbackDirs.py

is a good starting point, but we also need to be able to set the log level to warning (see #28987).

comment:6 Changed 7 weeks ago by teor

Actual Points: 0.5
Cc: nickm added
Points: 0.5
Reviewer: nickm
Status: newneeds_review

Hi Nick, would you mind doing a quick review on this fallback script pull request?
It's not urgent.

https://github.com/torproject/fallback-scripts/pull/6

I did this so I could get a US list, because my US machine is too small to handle the script.

It's based on #29100, because it needs the env var features of the script.
Please just review the last commit.

comment:7 Changed 7 weeks ago by teor

Parent ID: #28793

comment:8 Changed 7 weeks ago by teor

Keywords: fallback-ci added

comment:9 Changed 7 weeks ago by nickm

Status: needs_reviewmerge_ready

This LGTM, though I'm still not very good at Travis.

Does this do any expensive network stuff that Travis will get annoyed at us for? If not, I say merge.

comment:10 in reply to:  9 Changed 7 weeks ago by teor

Replying to nickm:

This LGTM, though I'm still not very good at Travis.

Does this do any expensive network stuff that Travis will get annoyed at us for? If not, I say merge.

Normally the script downloads 150 MB of Onionoo data, and about 250 MB of microdesc consensuses.

But I limited it to the top 200 relays using TOR_FB_ONIONOO_LIMIT=200, so it should only download about 10-20 MB total.
That's about the size of the rust or python install.

comment:11 Changed 7 weeks ago by nickm

Ok; that sounds reasonable.

comment:12 Changed 2 weeks ago by teor

Resolution: fixed
Status: merge_readyclosed

Merged as 60c0202, waiting for CI to merge the other changes.

Note: See TracTickets for help on using tickets.