Integrate PTs and bridge support into Tor Browser for Android

Right now there is bridge support into Orbot but a) it's not clear yet whether we keep Orbot and b) we probably want more PTs integrated and c) we need to clean up the interface (although #28329 (moved) will do work in that area).

This ticket is the parent ticket for more detailed work in case it is needed.

added GeorgKoppen201903 TBA-a3 TorBrowserTeam201904 component::applications/tor browser owner::tbb-team parent::27609 priority::very high resolution::fixed severity::normal sponsor::8 status::closed tbb-8.5-must-alpha tbb-mobile tbb-parity type::defect labels

https://github.com/guardianproject/AndroidPluggableTransports looks interesting.

Trac:
Cc: sysrqb to sysrqb, sisbell

Moving tickets to Jan 2019.

Trac:
Keywords: TorBrowserTeam201812 deleted, TorBrowserTeam201901 added

Trac:
Sponsor: N/A to Sponsor8

Moving tickets to February.

Trac:
Keywords: TorBrowserTeam201901 deleted, TorBrowserTeam201902 added

Trac:
Keywords: TorBrowserTeam201902 deleted, GeorgKoppen201903, TorBrowserTeam201903 added

After stopping to fiddle with unzipping and re-zipping .apk's to get the obfs4proxy binary at the correct place this was not overly hard anymore. Thanks to Nathan for this help! bug_28802 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_28802&id=1a5d368802706c3050db61430cb8b13287812229) in my tor-browser-build repo has a patch for review.

meek worked for me, however not the obfs4 bridges (they seemed to be down), so I wonder whether we should update the list to use the ones we ship for Tor Browser. For some reason I was not able to use bridges I got from BridgeDB. I entered them into Orbot's bridge settings but still the obfs4 ones were tried. That might be a thing we can solve with #28329 (moved), though.

Trac:
Keywords: TorBrowserTeam201903 deleted, TorBrowserTeam201903R added
Status: new to needs_review

bug_28802_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_28802_v2&id=1d499ff725ed6f1e279961f0a79d1fd9184fed55) has a rebased patch (mainly to take the changes made in #27210 (moved) into account).

Tickets on our radar for 8.5

Trac:
Keywords: N/A deleted, tbb-8.5 added

Trac:
Summary: Integrate PTs and bridge support into Tor Browser to Integrate PTs and bridge support into Tor Browser for Android

Introducing tbb-parity.

Trac:
Keywords: N/A deleted, tbb-parity added

bug_28802_v3 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_28802_v3&id=68730ec4ae152475f638cd52f79b6621412b3f85) has the updated version of the patch. I adjusted the commit message and a comment in the Orbot project slightly to take into account that we actually get bridge support for free by exposing the necessary UI e.g. with the patch in #28329 (moved).

I opened an issue to add back in support for PT in tor-android-service. Its a fairly simple fix.

https://github.com/sisbell/tor-android-service/issues/16

I'd like to add the copying of libraries as part of android-tor-service gradle build (since this should be included in the base library anyway). Then we can remove the the copying of libraries from the patch.

I tested out orbotservice from github and I'm not seeing the *.so libraries showing up in the aar (only tor.so from tor-android-binary). So I'm a little concerned that these may not also be missing from our final build. If you unzip the orbotservice aar are you seeing a lib directory with the PT libraries in there? Is so, then I think the approach is good. I'm going to dig more into orbotservice and see what's going on when I build.

On the build machine I used I see (after doing a unzip -d test orbotservice-release.aar):

~/tor-browser-build/out/orbot/orbot-0b5a48d4e086-android-armv7-419eca$ find -type f -name *.so
./test/jni/armeabi-v7a/obfs4proxy.so

Replying to gk:

On the build machine I used I see (after doing a unzip -d test orbotservice-release.aar): {{{ ~/tor-browser-build/out/orbot/orbot-0b5a48d4e086-android-armv7-419eca$ find -type f -name *.so ./test/jni/armeabi-v7a/obfs4proxy.so }}}

That looks good to me. The jni directory contents of the aar will show up under the lib directory of the apk.

Thanks, setting this as new, so we can do the right thing in the wake of #27609 (moved) (which means following comment:12)

Trac:
Keywords: TorBrowserTeam201903R deleted, TorBrowserTeam201903 added
Status: needs_review to new
Parent: N/A to #27609 (moved)

Marking blockers for Tor Browser 8.5.

Trac:
Keywords: tbb-8.5 deleted, tbb-8.5-must added

Tickets that block the next 8.5 alpha.

Trac:
Keywords: tbb-8.5-must deleted, tbb-8.5-must-alpha added

Moving tickets to April.

Trac:
Keywords: TorBrowserTeam201903 deleted, TorBrowserTeam201904 added

We get PT support after switching to TOPL, so we are good here. We have #28803 (moved) (and child tickets) for creating all those things the right way.

Trac:
Status: new to closed
Resolution: N/A to fixed

closed

mentioned in issue #29794 (moved)

moved to tpo/applications/tor-browser#28802 (closed)

mentioned in issue tpo/applications/tor-browser#29794 (closed)