Opened 8 months ago

Closed 3 months ago

#28802 closed defect (fixed)

Integrate PTs and bridge support into Tor Browser for Android

Reported by: gk Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, TBA-a3, GeorgKoppen201903, tbb-parity, tbb-8.5-must-alpha, TorBrowserTeam201904
Cc: sysrqb, sisbell Actual Points:
Parent ID: #27609 Points:
Reviewer: Sponsor: Sponsor8

Description

Right now there is bridge support into Orbot but a) it's not clear yet whether we keep Orbot and b) we probably want more PTs integrated and c) we need to clean up the interface (although #28329 will do work in that area).

This ticket is the parent ticket for more detailed work in case it is needed.

Child Tickets

Change History (20)

comment:2 Changed 6 months ago by gk

Keywords: TorBrowserTeam201901 added; TorBrowserTeam201812 removed

Moving tickets to Jan 2019.

comment:3 Changed 6 months ago by pili

Sponsor: Sponsor8

comment:4 Changed 6 months ago by gk

Keywords: TorBrowserTeam201902 added; TorBrowserTeam201901 removed

Moving tickets to February.

comment:5 Changed 5 months ago by gk

Keywords: TorBrowserTeam201903 GeorgKoppen201903 added; TorBrowserTeam201902 removed

comment:6 Changed 5 months ago by gk

Keywords: TorBrowserTeam201903R added; TorBrowserTeam201903 removed
Status: newneeds_review

After stopping to fiddle with unzipping and re-zipping .apk's to get the obfs4proxy binary at the correct place this was not overly hard anymore. Thanks to Nathan for this help! bug_28802 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_28802&id=1a5d368802706c3050db61430cb8b13287812229) in my tor-browser-build repo has a patch for review.

meek worked for me, however not the obfs4 bridges (they seemed to be down), so I wonder whether we should update the list to use the ones we ship for Tor Browser. For some reason I was not able to use bridges I got from BridgeDB. I entered them into Orbot's bridge settings but still the obfs4 ones were tried. That might be a thing we can solve with #28329, though.

comment:7 Changed 5 months ago by gk

comment:8 Changed 5 months ago by gk

Keywords: tbb-8.5 added

Tickets on our radar for 8.5

comment:9 Changed 4 months ago by boklm

Summary: Integrate PTs and bridge support into Tor BrowserIntegrate PTs and bridge support into Tor Browser for Android

comment:10 Changed 4 months ago by gk

Keywords: tbb-parity added

Introducing tbb-parity.

comment:11 Changed 4 months ago by gk

bug_28802_v3 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_28802_v3&id=68730ec4ae152475f638cd52f79b6621412b3f85) has the updated version of the patch. I adjusted the commit message and a comment in the Orbot project slightly to take into account that we actually get bridge support for free by exposing the necessary UI e.g. with the patch in #28329.

comment:12 Changed 4 months ago by sisbell

I opened an issue to add back in support for PT in tor-android-service. Its a fairly simple fix.

https://github.com/sisbell/tor-android-service/issues/16

I'd like to add the copying of libraries as part of android-tor-service gradle build (since this should be included in the base library anyway). Then we can remove the the copying of libraries from the patch.

comment:13 Changed 4 months ago by sisbell

I tested out orbotservice from github and I'm not seeing the *.so libraries showing up in the aar (only tor.so from tor-android-binary). So I'm a little concerned that these may not also be missing from our final build. If you unzip the orbotservice aar are you seeing a lib directory with the PT libraries in there? Is so, then I think the approach is good. I'm going to dig more into orbotservice and see what's going on when I build.

comment:14 Changed 4 months ago by gk

On the build machine I used I see (after doing a unzip -d test orbotservice-release.aar):

~/tor-browser-build/out/orbot/orbot-0b5a48d4e086-android-armv7-419eca$ find -type f -name *.so
./test/jni/armeabi-v7a/obfs4proxy.so

comment:15 in reply to:  14 Changed 4 months ago by sisbell

Replying to gk:

On the build machine I used I see (after doing a unzip -d test orbotservice-release.aar):

~/tor-browser-build/out/orbot/orbot-0b5a48d4e086-android-armv7-419eca$ find -type f -name *.so
./test/jni/armeabi-v7a/obfs4proxy.so

That looks good to me. The jni directory contents of the aar will show up under the lib directory of the apk.

comment:16 Changed 4 months ago by gk

Keywords: TorBrowserTeam201903 added; TorBrowserTeam201903R removed
Parent ID: #27609
Status: needs_reviewnew

Thanks, setting this as new, so we can do the right thing in the wake of #27609 (which means following comment:12)

comment:17 Changed 4 months ago by gk

Keywords: tbb-8.5-must added; tbb-8.5 removed

Marking blockers for Tor Browser 8.5.

comment:18 Changed 4 months ago by gk

Keywords: tbb-8.5-must-alpha added; tbb-8.5-must removed

Tickets that block the next 8.5 alpha.

comment:19 Changed 4 months ago by gk

Keywords: TorBrowserTeam201904 added; TorBrowserTeam201903 removed

Moving tickets to April.

comment:20 Changed 3 months ago by gk

Resolution: fixed
Status: newclosed

We get PT support after switching to TOPL, so we are good here. We have #28803 (and child tickets) for creating all those things the right way.

Note: See TracTickets for help on using tickets.