#28814 closed defect (fixed)

Backport 1480079 - Allow installing apps downloaded by Tor Browser

Reported by: sysrqb Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, TBA-a3, TorBrowserTeam201901R, GeorgKoppen201901
Cc: igt0 Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor8

Description

I expect some users may want to download an APK over Tor and then install it. Android will block this on recent versions because we don't declare the REQUEST_INSTALL_PACKAGES permission.

The patch is very small, we may want to write it ourselves instead of actually backporting because I think there will be a merge conflict.

https://bugzilla.mozilla.org/show_bug.cgi?id=1480079

Child Tickets

Change History (5)

comment:1 Changed 12 months ago by gk

Keywords: TorBrowserTeam201812 TBA-a3 added

comment:2 Changed 11 months ago by gk

Keywords: TorBrowserTeam201901 added; TorBrowserTeam201812 removed

Moving tickets to Jan 2019.

comment:3 Changed 11 months ago by gk

Keywords: TorBrowserTeam201901R GeorgKoppen201901 added; TorBrowserTeam201901 removed
Status: newneeds_review

bug_28814 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_28814&id=8ee6fbadffbe5a82b9162da03f52a470302bc32c) has the patch for review. I cherry-picked the patch and resolved the conflict (was not that hard).

Last edited 11 months ago by gk (previous) (diff)

comment:4 in reply to:  3 Changed 11 months ago by sysrqb

Status: needs_reviewmerge_ready

Replying to gk:

bug_28814 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_28814&id=8ee6fbadffbe5a82b9162da03f52a470302bc32c) has the patch for review. I cherry-picked the patch and resolved the conflict (was not that hard).

The patch looks good. I rebased it onto my branch for #28705 and tested it by downloading the signal apk and installing it. I also tested this on Android API levels 23 and 28.

comment:5 Changed 11 months ago by gk

Resolution: fixed
Status: merge_readyclosed

Thanks! This is now commit 4fe43cba0780a310cea820589ae0dc52837ebef9 on tor-browser-60.4.0esr-8.5-1.

Note: See TracTickets for help on using tickets.