Opened 10 months ago

#28830 new task

Clean up tor-browser-build build scripts/config files

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We should go over the projects we have in tor-browser-build and clean up build scripts and config files if needed.

Areas we could/should cover:

1) We sometimes have several platform related blocks in one build script which could be confusing. Can we merge those (or some of them) while still keeping the overall flow of the script logic?

2) Duplicating platform-specific and !platform-specific commands, e.g. cd $distdir in

[% IF c("var/osx") %]
  LIBEVENT_FILE=`basename $libeventdir/lib/libevent-*.dylib`
  cd $distdir
  cp bin/tor $TORBINDIR/
  cd $TORBINDIR/
  x86_64-apple-darwin11-install_name_tool -change $libeventdir/lib/$LIBEVENT_FILE @executable_path/$LIBEVENT_FILE tor
[% END %]

cd $distdir

3)...

Child Tickets

Change History (0)

Note: See TracTickets for help on using tickets.