Links on about:tor are not clickable anymore on Windows starting with 8.5a5

Since the fix for #27111 (moved) landed links on about:tor are not clickable anymore on Windows systems. In particular git bisect points to 61deb44d0c07eb1ec1d71eac2f0a7aeca87ea054.

Thanks to a cypherpunk who brought this up on our blog: https://blog.torproject.org/comment/278901#comment-278901.

added TorBrowserTeam201901R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal status::closed tbb-regression type::defect labels

Moving tickets to Jan 2019.

Trac:
Keywords: TorBrowserTeam201812 deleted, TorBrowserTeam201901 added

Closed #29058 (moved) as a duplicate.

Trac:
Cc: igt0 to igt0, traumschule

Kathy and I are working on this ticket. The problem affects all platforms when the window height is small. The root cause is the CSS that was added to always position the onion-pattern-container at the bottom of the page. That change causes the onion background to appear behind the links but also block clicking the links. We can fix this by adding z-index: -1 to the CSS. We should also think about whether we want to position the onion background at the bottom of the page on desktop or just let it stay within normal flow (as it was before the changes for #27111 (moved) landed).

Here is a patch for review: https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug28836-01&id=b5bf920e4aeb914900f6f70657c44e294436b5db

Please read the commit message for details.

Trac:
Keywords: TorBrowserTeam201901 deleted, TorBrowserTeam201901R added

I tested on desktop and mobile(and tablet) and it looks good.

Trac:

While testing on a Windows system I got

with the banner on. Is this expected? (Without the banner it looks fine)

Trac:
Status: new to needs_information

Replying to gk:

While testing on a Windows system I got ... with the banner on. Is this expected? (Without the banner it looks fine)

No, that is a bug. We had to remove a CSS rule related to the banner. Here is a revised patch: https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug28836-02&id=3d3a6b06de45f92bf87114272241d4964a87bec0

We did test with the banner both showing and hidden this time, although it would be great if someone could test again on mobile.

Trac:
Status: needs_information to needs_review

On mobile it looks great, with and without the banner. All the links are clickable.

Replying to mcs:

Replying to gk:

While testing on a Windows system I got ... with the banner on. Is this expected? (Without the banner it looks fine)

No, that is a bug. We had to remove a CSS rule related to the banner. Here is a revised patch: https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug28836-02&id=3d3a6b06de45f92bf87114272241d4964a87bec0

We did test with the banner both showing and hidden this time, although it would be great if someone could test again on mobile.

This works for me, too. On mobile I've tested the patch with my upcoming work for #29035 (moved). Merged to master (commit 0a628166a527bb643fa256e20332fbf54357697c).

mcs/brade which commit exactly did cause that (I am wondering about the need for backporting this. Marking this as tbb-backport so that we don't forget about it for now.)?

Trac:
Resolution: N/A to fixed
Keywords: N/A deleted, tbb-backport added
Status: needs_review to closed

Replying to gk:

mcs/brade which commit exactly did cause that (I am wondering about the need for backporting this. Marking this as tbb-backport so that we don't forget about it for now.)?

Non-clickable links on desktop were caused by 61deb44d0c07eb1ec1d71eac2f0a7aeca87ea054. Specifically, the first change to src/chrome/skin/aboutTor.css within that commit. You might want to double-check, but I don't think that change is in stable Tor Browser.

Correct, thanks.

Trac:
Keywords: tbb-backport deleted, N/A added

closed

mentioned in issue #29058 (moved)

moved to tpo/applications/tor-browser#28836 (closed)