Opened 6 months ago

Closed 5 months ago

Last modified 3 months ago

#28838 closed defect (implemented)

Make curve25519_basepoint_spot_check() faster

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: 0.3.4.9
Severity: Normal Keywords: startup performance 035-backport
Cc: Actual Points: 0
Parent ID: #28481 Points:
Reviewer: asn Sponsor: Sponsor8-can

Description

This function is currently around 9% of our startup time, and it does a bunch of curve25519 operations. We could make it a bunch faster, since our curve25519_basepoint function has not been observed to fail in the wild.

Child Tickets

Change History (9)

comment:1 Changed 6 months ago by nickm

Keywords: android controller removed

comment:2 Changed 6 months ago by nickm

Keywords: 035-backport added
Owner: set to nickm
Status: newaccepted

comment:3 Changed 6 months ago by nickm

Status: acceptedneeds_review

See branch ticket28835_035 in my public repository, with PR at https://github.com/torproject/tor/pull/585

This change is so simple that I think it would be safe to backport to Tor 0.3.5.

comment:4 Changed 6 months ago by dgoulet

Very simple, lgtm;

I'm not familiar enough with this though to judge how much that is a "bad" idea vs "good" idea. So I'll rely on you for the reasoning behind this choice. Apart from that, trivial change.

comment:5 Changed 6 months ago by dgoulet

Reviewer: asn

comment:6 Changed 5 months ago by asn

Status: needs_reviewmerge_ready

LGTM. Maybe we can also consider moving this check on the unittests.

comment:7 Changed 5 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged to 0.3.5 and forward; I think we already do more spot-checking than this in the unit tests.

comment:8 Changed 5 months ago by nickm

Actual Points: 0

comment:9 Changed 3 months ago by teor

Milestone: Tor: 0.4.0.x-finalTor: 0.3.5.x-final

Merged to 0.3.5.

Note: See TracTickets for help on using tickets.