Opened 5 months ago

Closed 5 months ago

#28840 closed enhancement (implemented)

Allow HeartbeatPeriod of less than 30 minutes in testing Tor networks

Reported by: robgjansen Owned by:
Priority: Low Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Trivial Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: ahf Sponsor:

Description

The minimum value currently allowed for the HeartbeatPeriod config option is 30 minutes.

It is useful in testing Tor networks (TestingTorNetwork 1) to log heartbeat information more often than every 30 minutes.

This is a request to change Tor so that it does not enforce a minimum value for the HeartbeatPeriod in the case that TestingTorNetwork is set to 1. Patch attached.

Child Tickets

Attachments (1)

0001-allow-any-value-for-HearbeatPeriod-in-testing-Tor-ne.patch (947 bytes) - added by robgjansen 5 months ago.
Two line requested change to not apply min heartbeat period in test networks.

Download all attachments as: .zip

Change History (7)

Changed 5 months ago by robgjansen

Two line requested change to not apply min heartbeat period in test networks.

comment:1 Changed 5 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.4.0.x-final
Status: newneeds_review

needs a changes file, but looks plausible.

comment:3 Changed 5 months ago by nickm

Made a PR at https://github.com/torproject/tor/pull/595 so CI can have a run at it

comment:4 Changed 5 months ago by dgoulet

Reviewer: ahf

comment:5 Changed 5 months ago by ahf

Status: needs_reviewmerge_ready

I think this looks good since it only affects nodes where TestingTorNetwork is enabled. I often comment out this minimum check myself when I need to test stuff.

comment:6 Changed 5 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

ok, merged!

Note: See TracTickets for help on using tickets.