Opened 12 months ago

Last modified 11 months ago

#28845 new enhancement

evloop could be better at handling fork() in tests

Reported by: ahf Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords: 041-proposed
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

For #28179 we saw an issue on kqueue() based systems where if tests were run with TT_FORK the event could fail with an invalid FD error message (EBADF).

Child Tickets

Change History (5)

comment:1 Changed 12 months ago by ahf

The error can be seen here:

https://travis-ci.org/ahf/tor/jobs/471094512

slow/process/callbacks: [forking] [warn] kevent: Bad file descriptor
Dec 21 18:27:55.660 [err] libevent call with kqueue failed: Bad file descriptor [9]
  FAIL src/test/test_process_slow.c:188: assert(ret OP_EQ 0): -1 vs 0
  FAIL src/test/test_process_slow.c:243: assert(smartlist_len(process_data->stdout_data) OP_EQ 12): 0 vs 12
  [callbacks FAILED]
slow/process/callbacks_terminate: [forking] [warn] kevent: Bad file descriptor
Dec 21 18:27:56.036 [err] libevent call with kqueue failed: Bad file descriptor [9]
  FAIL src/test/test_process_slow.c:188: assert(ret OP_EQ 0): -1 vs 0
  FAIL src/test/test_process_slow.c:331: assert(process_data->did_exit)
  [callbacks_terminate FAILED]
2/14 TESTS FAILED. (0 skipped)
FAIL src/test/test-slow (exit status: 1)

comment:2 Changed 11 months ago by gaba

Sponsor: Sponsor8Sponsor19-must

comment:3 Changed 11 months ago by nickm

Sponsor: Sponsor19-must

comment:4 Changed 11 months ago by nickm

Keywords: 041-proposed added
Milestone: Tor: 0.4.0.x-finalTor: unspecified

Mark some 0.4.0.x tickets as proposed for 0.4.1.x

comment:5 Changed 11 months ago by ahf

Parent ID: #28179
Note: See TracTickets for help on using tickets.