Opened 2 months ago

Closed 2 months ago

#28846 closed enhancement (implemented)

Use K/V parser for handling PT LOG and STATUS messages

Reported by: ahf Owned by:
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #28179 Points:
Reviewer: dgoulet Sponsor: Sponsor8

Description

Nick wrote a K/V string parser that is currently available in master. Let's make use of that for handling PT LOG and STATUS messages from PT processes' stdout.

Child Tickets

Change History (5)

comment:1 Changed 2 months ago by ahf

Reviewer: dgoulet
Status: newneeds_review

comment:2 Changed 2 months ago by dgoulet

Status: needs_reviewmerge_ready

lgtm;

comment:3 Changed 2 months ago by nickm

Status: merge_readyneeds_revision

Hi! I've left a note on the review. Briefly, could you please pass the data variable through "escaped()" before logging it? That way we'll avoid trouble with confusing the PT logs and Tor's logs.

comment:4 Changed 2 months ago by ahf

Status: needs_revisionneeds_review

Fixed in ab0d7d2dd470a447535eaf7c35bd4877c43bce26

comment:5 Changed 2 months ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Merged!

Note: See TracTickets for help on using tickets.