Opened 5 months ago

Closed 5 months ago

#28856 closed defect (implemented)

Discard strcmp_len()

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version: Tor: 0.3.4.9
Severity: Normal Keywords: android startup performance controller
Cc: Actual Points: .3
Parent ID: #28481 Points:
Reviewer: mikeperry Sponsor: Sponsor8-can

Description

We have a strcmp_len() function that we use extensively in parsecommon. But it's just a messed-up version of strncmp. We can get better performance here if we drop it.

Child Tickets

Change History (6)

comment:1 Changed 5 months ago by nickm

oh wait, these are _slightly_ different. More thought needed here. :/

comment:2 Changed 5 months ago by nickm

Actual Points: .3
Status: assignedneeds_review

See branch ticket28856_v2; PR at https://github.com/torproject/tor/pull/596

comment:3 Changed 5 months ago by dgoulet

Reviewer: teor

comment:4 Changed 5 months ago by asn

Reviewer: teormikeperry

comment:5 Changed 5 months ago by mikeperry

Status: needs_reviewmerge_ready

Looks good. Little sad about the test coverage reduction, but not that sad. V simple fucntion.

comment:6 Changed 5 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

I am pretty sure that the coverage reduction is not the fault of this patch in any way I can see. Merging. Thanks!

Note: See TracTickets for help on using tickets.