Changes between Initial Version and Version 1 of Ticket #28866, comment 7


Ignore:
Timestamp:
Feb 14, 2019, 6:37:37 PM (9 months ago)
Author:
mikeperry
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28866, comment 7

    initial v1  
    1 Hrmm. I might need to look at a lot more of the sbws code, but I don't think the patch is the best way to do this. If the queue can also be added from another thread, then there still can be a race where it ends up full after the loop check but before the next statement. I would instead make it do something like:
     1Hrmm. I might need to look at a lot more of the sbws code, but I don't think the patch is the best way to address the possibility that the queue may be full. If the queue can also be added from another thread, then there still can be a race where it ends up full after the loop check but before the next statement. I would instead make it do something like:
    22
    33{{{