Opened 7 months ago

Last modified 6 months ago

#28875 new defect

Running Tor Browser 8.x debug builds crashes on Windows during first start

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-crash
Cc: tom Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

For #28874 I tried to create a debug build for Windows in order to get more information from a user on what is going on on their machine. While testing the debug build myself it turns out it crashes in different ways when running, making this approach of debugging #28874 unusable. On first start it crashes with:

Assertion failure: mState == FAILED || mState == STARTED || mState == CLONED (St
ate invariants violated), at /var/tmp/build/firefox-2bb5c165697d/widget/windows/
AudioSession.cpp:344
#01: mozilla_dump_image[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.
dll +0x25b7bed]
#02: mozilla_dump_image[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.
dll +0x25b7c2d]
#03: mozilla_dump_image[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.
dll +0x22a5ec8]
#04: mozilla_dump_image[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.
dll +0x22a71bd]
#05: mozilla_dump_image[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.
dll +0x22a76bd]
#06: mozilla_dump_image[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.
dll +0x22a8add]
#07: mozilla_dump_image[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.
dll +0x116abff]
#08: mozilla_dump_image[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.
dll +0x116b0cd]
#09: mozilla_dump_image[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.
dll +0x116b348]
#10: DumpBidiLine[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.dll +0
x2a682ec]
#11: XRE_GetBootstrap[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.dl
l +0x41b76e0]
#12: mozilla_dump_image[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.
dll +0xf8fa20]
#13: mozilla_dump_image[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.
dll +0x112aa4f]
#14: mozilla_dump_image[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.
dll +0x1d6c758]
#15: XRE_GetBootstrap[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.dl
l +0x4207b15]
#16: mozilla_dump_image[C:\Users\AMO_Test\Desktop\Tor Browser_web[Cghlil\dB 4r0o
1w2,s eMari\n xTuhrle.add]l WlA RN+I0NGx:1 N1o5 C6IdD 3f0ou]n
 w#h1en7 :at tmemopztiinlg ltao _mdapu mcopn_triamcta gIDe:[ fCi:le\ U/vsaer/rts
m\p/AbMuiOl_d/Tfeirsetfo\xD-2ebsb5kct16o5p69\7Td/oxrpc oBm/rcoomwpsoneernt_sw/ne
sbCogmlpo\nBenrtoMawnsageerr.\cxppu,l l.idnel l50 8+
0x1381927]
#18: mozilla_dump_image[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.
dll +0x198814e]
#19: XRE_GetBootstrap[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.dl
l +0x431a8ec]
#20: XRE_GetBootstrap[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.dl
l +0x3c4083c]
#21: XRE_GetBootstrap[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.dl
l +0x3c40bef]
#22: XRE_GetBootstrap[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.dl
l +0x3c40d62]
#23: XRE_GetBootstrap[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.dl
l +0x3995f86]
#24: XRE_GetBootstrap[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.dl
l +0x3933d02]
#25: XRE_GetBootstrap[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.dl
l +0x398ef69]
#26: XRE_GetBootstrap[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.dl
l +0x398f04b]
#27: XRE_GetBootstrap[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.dl
l +0x431a8ec]
#28: XRE_GetBootstrap[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.dl
l +0x3c40b2a]
#29: XRE_GetBootstrap[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.dl
l +0x3c40bef]
#30: XRE_GetBootstrap[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.dl
l +0x3c33224]
#31: XRE_GetBootstrap[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.dl
l +0x3c40386]
#32: XRE_GetBootstrap[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.dl
l +0x3c408dd]
#33: XRE_GetBootstrap[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.dl
l +0x3c40bef]
#34: XRE_GetBootstrap[C:\Users\AMO_Test\Desktop\Tor Browser_webgl\Browser\xul.dl
l +0x3d078ad]
#35: ??? (???:???)
Hit MOZ_CRASH(accessing non-early pref privacy.spoof_english before late prefs a
re set) at /var/tmp/build/firefox-2bb5c165697d/modules/libpref/Preferences.cpp:9
32

On subsequent starts I only hit the MOZ_CRASH in the above output but the browser is unusable:

WARNING: No CID found when attempting to map contract ID: file /path/to/nsComponentManager.cpp, line 508
Hit MOZ_CRASH(accessing non-early pref privacy.spoof_english before late prefs set) at /path/to/Preferences.cpp:932

Child Tickets

Change History (5)

comment:1 in reply to:  description Changed 7 months ago by gk

Summary: Running Tor Browser debug builds on Windows crashesRunning Tor Browser 8.x debug builds crashes

Replying to gk:

On subsequent starts I only hit the MOZ_CRASH in the above output but the browser is unusable:

WARNING: No CID found when attempting to map contract ID: file /path/to/nsComponentManager.cpp, line 508
Hit MOZ_CRASH(accessing non-early pref privacy.spoof_english before late prefs set) at /path/to/Preferences.cpp:932

I hit that one on a Linux system, too fwiw.

comment:2 Changed 7 months ago by tom

The non-early pref assert can be fixed by adding it around here: https://dxr.mozilla.org/mozilla-esr60/source/dom/ipc/ContentPrefs.cpp#295

comment:3 in reply to:  2 Changed 7 months ago by gk

Keywords: TorBrowserTeam201812R added
Status: newneeds_review

Replying to tom:

The non-early pref assert can be fixed by adding it around here: https://dxr.mozilla.org/mozilla-esr60/source/dom/ipc/ContentPrefs.cpp#295

Yep, that works. I've bug_28875 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_28875&id=8cac0295141b960b1c56d956865af64f7af7208d) in my tor-browser repo for a possible fix (it's on top of the patches for #27597).

I've created an upstream bug for fixing this in Mozilla's code: https://bugzilla.mozilla.org/show_bug.cgi?id=1515001.

Last edited 6 months ago by gk (previous) (diff)

comment:4 Changed 7 months ago by gk

Keywords: TorBrowserTeam201812R removed
Summary: Running Tor Browser 8.x debug builds crashesRunning Tor Browser 8.x debug builds crashes on Windows during first start

Thanks tom for getting this landed. I'll clearing review as we'll get that fix in the next ESR point release. Changing the description to focus on Windows and the assertion we hit on first start.

comment:5 Changed 7 months ago by gk

Status: needs_reviewnew
Note: See TracTickets for help on using tickets.