Opened 10 months ago

Last modified 6 months ago

#28876 reopened defect

tbb-testsuite: fix the noscript test

Reported by: boklm Owned by: cypherpunks
Priority: Medium Milestone:
Component: Applications/Quality Assurance and Testing Version:
Severity: Normal Keywords: tbb-testsuite, boklm201812, TorBrowserTeam201812
Cc: tbb-team Actual Points:
Parent ID: #27105 Points:
Reviewer: Sponsor:

Description

The noscript test is currently failing, because it is trying to use the noscript.global pref to enable/disable noscript, which is not used anymore by the new version of noscript.

To test the different states of noscript, we can instead change the security level.

Child Tickets

Change History (6)

comment:1 Changed 10 months ago by gk

There are a bunch of other XPCOM related prefs, too, that are checked. Do we need more work on that test than just deleting those preferences checks or is it just that?

comment:2 Changed 10 months ago by boklm

After deleting those preferences checks, the test fails with:

TEST-UNEXPECTED-FAIL | test_noscript.py Test.test_noscript | AssertionError: http page with https iframe

The test is loading this http page containing an https iframe:
http://test-data.tbb.mars-attacks.org/noscript/https_iframe.html

(you should first visit the https version of the page to add an exception for the self-signed certificate: https://test-data.tbb.mars-attacks.org/noscript/https_iframe.html)

It seems this is the issue from #28873.

comment:3 Changed 10 months ago by boklm

In commit ec335e618ab29ee29baa4e8a27d8e870a3865b92 I removed the preferences checks. The test should now pass once #28873 is fixed.

comment:4 Changed 10 months ago by gk

Resolution: fixed
Status: newclosed

Fixed with the update to NoScript 10.2.1 on master (commit b32e182633bba7733b635bc5dd0fcbd55436f4d7) and maint-8.0 (commit b35cea6792f294d0a625fde5595f1c96a8a2a72a).

comment:5 Changed 9 months ago by boklm

Resolution: fixed
Status: closedreopened

The test is working when I run it locally. However it is still failing on the test machine.

comment:6 Changed 6 months ago by boklm

I temporarily disabled the noscript test with commit e5f40b6ebbed106f4316e083d983275b75b5f652.

Note: See TracTickets for help on using tickets.