Opened 4 months ago

Closed 4 months ago

#28879 closed defect (fixed)

send_resolved_hostname_cell(): Assert first, strlen after.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 035-backport
Cc: Actual Points:
Parent ID: Points: 0
Reviewer: catalyst Sponsor:

Description

Found with scan-build.

Child Tickets

Change History (4)

comment:1 Changed 4 months ago by nickm

Keywords: 035-backport added
Status: assignedneeds_review

See branch ticket28879; PR at https://github.com/torproject/tor/pull/597

I suggest that we backport this to 035 and no farther, since it isn't actually reachable today.

(Edited to fix the PR URL-

Last edited 4 months ago by nickm (previous) (diff)

comment:2 Changed 4 months ago by dgoulet

Reviewer: catalyst

comment:3 Changed 4 months ago by catalyst

Status: needs_reviewmerge_ready

Looks good to me!

comment:4 Changed 4 months ago by nickm

Milestone: Tor: 0.4.0.x-finalTor: 0.3.5.x-final
Resolution: fixed
Status: merge_readyclosed

Thanks! Merged to 0.3.5 and forward.

Note: See TracTickets for help on using tickets.