Opened 10 months ago

Closed 10 months ago

Last modified 7 months ago

#28881 closed defect (fixed)

Initialize addr in parse_port_config

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Trivial Keywords: scan-build 035-backport
Cc: Actual Points: 0
Parent ID: Points: 0
Reviewer: ahf Sponsor:

Description

Scan-build can't convince itself that the "addr" variable in parse_port_config() is always initialized before use.

Child Tickets

Change History (6)

comment:1 Changed 10 months ago by nickm

Actual Points: 0
Status: assignedneeds_review

Branch is ticket28881_035; PR at https://github.com/torproject/tor/pull/599

comment:2 Changed 10 months ago by dgoulet

Reviewer: ahf

comment:3 Changed 10 months ago by ahf

Status: needs_reviewmerge_ready

Looks good, except one small detail that should be fixed before it lands. There is a typo in the changes file: configuratio -> configuration.

comment:4 Changed 10 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Thanks, fixed & merged!

comment:5 Changed 7 months ago by teor

Keywords: 035-backport removed

Not backported.

comment:6 Changed 7 months ago by teor

Keywords: 035-backport added
Milestone: Tor: 0.4.0.x-finalTor: 0.3.5.x-final

Hmm, actually, was backported in merge 702fd6f0f2.

Note: See TracTickets for help on using tickets.