Opened 4 months ago

Closed 4 months ago

#28883 closed defect (fixed)

If many log messages are sent, test_rebind.py does not wait for 60 seconds

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: rl1987, teor Actual Points:
Parent ID: Points: 0
Reviewer: ahf Sponsor:

Description

The test_rebind.py script does not wait a full 60 seconds if it receives 600 log messages. This is probably not intended, right?

Child Tickets

Change History (6)

comment:1 Changed 4 months ago by nickm

Cc: teor added
Status: assignedneeds_review

See branch ticket28883_035 with PR at https://github.com/torproject/tor/pull/600

comment:2 Changed 4 months ago by dgoulet

Reviewer: ahf

comment:3 Changed 4 months ago by ahf

Status: needs_reviewmerge_ready

Looks good.

comment:4 Changed 4 months ago by nickm

Great!

I'll give this another day or so in case teor or rl1987 thinks that I am doing it wrong. :)

comment:5 Changed 4 months ago by rl1987

Patch seems correct to me.

comment:6 Changed 4 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Thanks! Merging to 0.3.5 and forward.

Note: See TracTickets for help on using tickets.