Opened 5 months ago

Closed 4 months ago

#28894 closed defect (fixed)

Remove Torbutton parts of fix for #20244

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-torbutton, TorBrowserTeam201901R
Cc: igt0 Actual Points:
Parent ID: #28745 Points:
Reviewer: Sponsor:

Description

When rebasing our patches to esr60 in #25543 the tor-browser patches had been marked as obsolete and omitted as we thought we'd avoid users shooting themselves in their feet by exposing those important preferences on the about:preferences#privacy pane. However, the Torbutton parts still live on in the repo.

Child Tickets

Change History (6)

comment:1 Changed 5 months ago by gk

Keywords: TorBrowserTeam201812R added
Status: newneeds_review

comment:2 Changed 5 months ago by gk

Keywords: TorBrowserTeam201901R added; TorBrowserTeam201812R removed

Moving review tickets to 2019.

comment:3 Changed 4 months ago by mcs

Keywords: TorBrowserTeam201901 added; TorBrowserTeam201901R removed
Status: needs_reviewneeds_revision

Kathy and I reviewed these changes and have a couple of comments:
A) src/jar.mn includes a reference to privacy-prefs-overlay.xul which should be removed.
B) Maybe we are missing something, but we think the following additional entities are no longer used (and therefore should be removed from the .dtd files):

  • torbutton.prefs.restrict_thirdparty
  • torbutton.prefs.restrict_thirdparty_tooltip
  • torbutton.prefs.resist_fingerprinting
  • torbutton.prefs.resist_fingerprinting_tooltip

comment:4 Changed 4 months ago by gk

Keywords: TorBrowserTeam201901R added; TorBrowserTeam201901 removed
Status: needs_revisionneeds_review

comment:5 Changed 4 months ago by mcs

r=brade, r=mcs
Thanks for the updated patch. This looks good now.

comment:6 Changed 4 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks! Fixed with commit 129149cf02c4888f6997fe3396909c8ba2c5edcb.

Note: See TracTickets for help on using tickets.