Remove Torbutton parts of fix for #20244

When rebasing our patches to esr60 in #25543 (moved) the tor-browser patches had been marked as obsolete and omitted as we thought we'd avoid users shooting themselves in their feet by exposing those important preferences on the about:preferences#privacy pane. However, the Torbutton parts still live on in the repo.

Trac:
Parent Ticket: #28745 (moved)

added TorBrowserTeam201901R component::applications/tor browser owner::tbb-team parent::28745 priority::medium resolution::fixed severity::normal status::closed tbb-torbutton type::defect labels

bug_28894 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_28894&id=afcfa2998155801ad23e18a20216ef932e3c1a35) has a proposed fix for review.

Trac:
Status: new to needs_review
Keywords: N/A deleted, TorBrowserTeam201812R added

Moving review tickets to 2019.

Trac:
Keywords: TorBrowserTeam201812R deleted, TorBrowserTeam201901R added

Kathy and I reviewed these changes and have a couple of comments: A) src/jar.mn includes a reference to privacy-prefs-overlay.xul which should be removed. B) Maybe we are missing something, but we think the following additional entities are no longer used (and therefore should be removed from the .dtd files):

• torbutton.prefs.restrict_thirdparty
• torbutton.prefs.restrict_thirdparty_tooltip
• torbutton.prefs.resist_fingerprinting
• torbutton.prefs.resist_fingerprinting_tooltip

Trac:
Status: needs_review to needs_revision
Keywords: TorBrowserTeam201901R deleted, TorBrowserTeam201901 added

Good points. See bug_28894_v2 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_28894_v2&id=129149cf02c4888f6997fe3396909c8ba2c5edcb) for an updated patch.

Trac:
Keywords: TorBrowserTeam201901 deleted, TorBrowserTeam201901R added
Status: needs_revision to needs_review

r=brade, r=mcs Thanks for the updated patch. This looks good now.

Thanks! Fixed with commit 129149cf02c4888f6997fe3396909c8ba2c5edcb.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

moved to tpo/applications/tor-browser#28894 (closed)