Opened 10 months ago

Closed 7 weeks ago

Last modified 5 weeks ago

#28896 closed task (fixed)

Make sure our bundled WebExtensions are running in Private Browsing Mode

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff68-esr TorBrowserTeam201908R
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor44-can

Description

We might need to flip a pref to allow our bundled WebExtensions to run in Private Browsing Mode starting with ESR 68. See:

https://bugzilla.mozilla.org/show_bug.cgi?id=1511636
https://bugzilla.mozilla.org/show_bug.cgi?id=1457001

for context.

Child Tickets

Change History (9)

comment:1 Changed 5 months ago by gk

#29192 is a duplicate.

comment:2 Changed 5 months ago by acat

Setting extensions.allowPrivateBrowsingByDefault = true should do it: https://github.com/acatarineu/tor-browser/commit/28896.

comment:3 Changed 2 months ago by pili

Sponsor: Sponsor44-can

Adding Sponsor 44 to ESR68 tickets

comment:4 Changed 7 weeks ago by acat

Keywords: TorBrowserTeam201908R added
Status: newneeds_review

comment:5 Changed 7 weeks ago by gk

Cc: tbb-team added
Status: needs_reviewneeds_information

I actually think we are good for our own extensions. System extensions are good by default it seems and extensions already running/being shipped with are getting whitelisted during migration (see the resulting extensions.webextensions.ExtensionStorageIDB.migrated.https-everywhere-eff@eff.org etc.). Thus I think this is cool for getting extension updates as well. That is: updates whitelisted won't break if never versions are up for download.

There is the rest risk of Mozilla messing this up vs. better protection against random extensions in Tor's default mode. Right now, I am leaning towards following Mozilla's defaults, though, just doing #31555. Thoughts?

comment:6 Changed 7 weeks ago by gk

Some additional reading material is over at: https://support.mozilla.org/en-US/kb/extensions-private-browsing.

comment:7 Changed 7 weeks ago by acat

Not completely sure about this one.

What I had thought was: by default in Tor Browser we only have private windows, so it makes sense to always enable extensions. Otherwise from the user perspective it will be broken behaviour: they might install an extension and see no change (icons, etc.), then maybe file bugs.

It may work as a protection against something that we don't support: installing extensions others than the shipped ones. But, at the end of the day, we do not forbid installing extensions either, so this change might be surprising for users.

comment:8 in reply to:  7 Changed 7 weeks ago by gk

Resolution: fixed
Status: needs_informationclosed

Replying to acat:

Not completely sure about this one.

What I had thought was: by default in Tor Browser we only have private windows, so it makes sense to always enable extensions. Otherwise from the user perspective it will be broken behaviour: they might install an extension and see no change (icons, etc.), then maybe file bugs.

It may work as a protection against something that we don't support: installing extensions others than the shipped ones. But, at the end of the day, we do not forbid installing extensions either, so this change might be surprising for users.

Okay, that's not unreasonable. After all the users might not know (and should not need to know) that they are in a special mode. They just want to have a working browser and installing extensions is surely working without issues in a vanilla Firefox, right? Let's take your patch then. We can revisit that decision later on if needed. Cherry-picked onto tor-browser-68.1.0esr-9.0-1 (commit 8aabfb8128a8125a00d0a36d41518379258e0b38).

Note: See TracTickets for help on using tickets.