Opened 5 weeks ago

Last modified 36 hours ago

#28913 merge_ready defect

Base32_decode should return the length of its result.

Reported by: nickm Owned by: nickm
Priority: Low Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: util tor-client base32 cleanup technical-debt 041-proposed
Cc: Actual Points:
Parent ID: #19531 Points: .1
Reviewer: dgoulet Sponsor:

Description

The base32_decode() API, for consistency with base64_decode, should return the number of bytes written.

This would also enable us to fuzz it with fuzz_strops.c

Child Tickets

Change History (6)

comment:1 Changed 5 weeks ago by nickm

Status: assignedneeds_review

Branch is ticket28913; PR at https://github.com/torproject/tor/pull/611 .

comment:2 Changed 5 weeks ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewneeds_revision

Left a single comment. If you agree, lets change it else I'm fine and lets get it merged. Up to you nick!

comment:3 Changed 5 weeks ago by nickm

the change you propose looks good to me, but I don't have time to do it right now. Will try later, unless you can pick it up.

comment:4 Changed 6 days ago by nickm

Keywords: 041-proposed added
Milestone: Tor: 0.4.0.x-finalTor: 0.4.1.x-final

comment:5 Changed 5 days ago by nickm

Status: needs_revisionneeds_review

I've made the requested change; we can review this again in 0.4.1.

comment:6 Changed 36 hours ago by dgoulet

Status: needs_reviewmerge_ready

ack.

Note: See TracTickets for help on using tickets.