Base32_decode should return the length of its result.

The base32_decode() API, for consistency with base64_decode, should return the number of bytes written.

This would also enable us to fuzz it with fuzz_strops.c

changed milestone to %Tor: 0.4.1.x-final

Trac:
Parent Ticket: #19531 (moved)

added 041-proposed asn-merge base32 cleanup component::core tor/tor milestone::Tor: 0.4.1.x-final owner::nickm parent::19531 points::.1 priority::low resolution::fixed reviewer::dgoulet severity::normal status::closed technical-debt tor-client type::defect util labels

Branch is ticket28913; PR at https://github.com/torproject/tor/pull/611 .

Trac:
Status: assigned to needs_review

Left a single comment. If you agree, lets change it else I'm fine and lets get it merged. Up to you nick!

Trac:
Reviewer: N/A to dgoulet
Status: needs_review to needs_revision

the change you propose looks good to me, but I don't have time to do it right now. Will try later, unless you can pick it up.

Trac:
Keywords: util tor-client base32 cleanup technical-debt deleted, util tor-client base32 cleanup technical-debt 041-proposed added
Milestone: Tor: 0.4.0.x-final to Tor: 0.4.1.x-final

I've made the requested change; we can review this again in 0.4.1.

Trac:
Status: needs_revision to needs_review

ack.

Trac:
Status: needs_review to merge_ready

Trac:
Keywords: util tor-client base32 cleanup technical-debt 041-proposed deleted, util tor-client base32 cleanup technical-debt 041-proposed asn-merge added

Merged to master!

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed

closed

changed time estimate to 48m

mentioned in issue #34400 (moved)

moved to tpo/core/tor#28913 (closed)

mentioned in issue tpo/core/tor#34400 (closed)