Opened 5 months ago

Closed 4 months ago

#28920 closed defect (fixed)

rep_hist_log_link_protocol_counts() only knows about 4 link protocols, but Tor has 5

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version: Tor: 0.3.1.1-alpha
Severity: Normal Keywords: easy, fast-fix
Cc: Actual Points:
Parent ID: Points:
Reviewer: nickm Sponsor:

Description

Maybe we should just log all the versions in a loop?

Child Tickets

Change History (5)

comment:1 Changed 5 months ago by rl1987

https://github.com/torproject/tor/pull/618/files

Note that calling log_notice() in each loop iteration would break some testcases in test_status.c.

comment:2 Changed 5 months ago by rl1987

Status: newneeds_review

comment:3 Changed 5 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.4.0.x-final

comment:4 Changed 5 months ago by dgoulet

Reviewer: teor

comment:5 Changed 4 months ago by nickm

Resolution: fixed
Reviewer: teornickm
Status: needs_reviewclosed

LGTM; cherry-picking to 0.3.5 [LTS] and merging forward.

Note: See TracTickets for help on using tickets.