Opened 4 weeks ago

Closed 4 weeks ago

Last modified 2 weeks ago

#28924 closed defect (fixed)

Our make V=1 logs have become too verbose for travis

Reported by: nickm Owned by: nickm
Priority: High Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 035-backport, tor-ci
Cc: catalyst Actual Points: .1
Parent ID: Points:
Reviewer: Sponsor: Sponsor8-can

Description

For some reason, Travis thinks that it's unreasonable for us to log this kind of thing for with clang command line:

clang -DHAVE_CONFIG_H -I.  -I./src -I./src/ext -I./src/ext/trunnel
  -I./src/trunnel -I./src/ext -Isrc/ext -DSHARE_DATADIR="\"/usr/local/share\""
  -DLOCALSTATEDIR="\"/usr/local/var\"" -DBINDIR="\"/usr/local/bin\""
  -DTOR_UNIT_TESTS -DHAVE_MODULE_DIRAUTH=1 -ftrapv -fsanitize=address
  -fsanitize=undefined -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2
  -Qunused-arguments -fstack-protector-all -Wstack-protector --param
  ssp-buffer-size=1 -fPIE -fno-omit-frame-pointer -fasynchronous-unwind-tables
  -Wall -fno-strict-aliasing -Waddress -Waddress-of-array-temporary
  -Waddress-of-temporary -Wambiguous-macro -Wanonymous-pack-parens -Warc
  -Warc-bridge-casts-disallowed-in-nonarc -Warc-maybe-repeated-use-of-weak
  -Warc-performSelector-leaks -Warc-repeated-use-of-weak -Warray-bounds
  -Warray-bounds-pointer-arithmetic -Wasm -Wasm-operand-widths
  -Watomic-properties -Watomic-property-with-user-defined-accessor -Wauto-import
  -Wauto-storage-class -Wauto-var-id -Wavailability -Wbackslash-newline-escape
  -Wbind-to-temporary-copy -Wbitfield-constant-conversion -Wbool-conversion
  -Wbool-conversions -Wbuiltin-requires-header -Wchar-align
  -Wcompare-distinct-pointer-types -Wcomplex-component-init
  -Wconditional-type-mismatch -Wconfig-macros -Wconstant-conversion
  -Wconstant-logical-operand -Wconstexpr-not-const -Wcustom-atomic-properties
  -Wdangling-field -Wdangling-initializer-list -Wdate-time
  -Wdelegating-ctor-cycles -Wdeprecated-implementations -Wdeprecated-register
  -Wdirect-ivar-access -Wdiscard-qual -Wdistributed-object-modifiers
  -Wdivision-by-zero -Wdollar-in-identifier-extension -Wdouble-promotion
  -Wduplicate-decl-specifier -Wduplicate-enum -Wduplicate-method-arg
  -Wduplicate-method-match -Wdynamic-class-memaccess -Wembedded-directive
  -Wempty-translation-unit -Wenum-conversion -Wexit-time-destructors
  -Wexplicit-ownership-type -Wextern-initializer -Wextra -Wextra-semi
  -Wextra-tokens -Wflexible-array-extensions -Wfloat-conversion -Wformat-non-iso
  -Wfour-char-constants -Wgcc-compat -Wglobal-constructors
  -Wgnu-array-member-paren-init -Wgnu-designator -Wgnu-static-float-init
  -Wheader-guard -Wheader-hygiene -Widiomatic-parentheses -Wignored-attributes
  -Wimplicit-atomic-properties -Wimplicit-conversion-floating-point-to-bool
  -Wimplicit-exception-spec-mismatch -Wimplicit-fallthrough
  -Wimplicit-fallthrough-per-function -Wimplicit-retain-self
  -Wimport-preprocessor-directive-pedantic -Wincompatible-library-redeclaration
  -Wincompatible-pointer-types-discards-qualifiers -Wincomplete-implementation
  -Wincomplete-module -Wincomplete-umbrella -Winit-self -Wint-conversions
  -Wint-to-void-pointer-cast -Winteger-overflow -Winvalid-constexpr
  -Winvalid-iboutlet -Winvalid-noreturn -Winvalid-pp-token
  -Winvalid-source-encoding -Winvalid-token-paste -Wknr-promoted-parameter
  -Wlarge-by-value-copy -Wliteral-conversion -Wliteral-range
  -Wlocal-type-template-args -Wloop-analysis -Wmain-return-type
  -Wmalformed-warning-check -Wmethod-signatures -Wmicrosoft -Wmicrosoft-exists
  -Wmismatched-parameter-types -Wmismatched-return-types
  -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-noreturn
  -Wmissing-selector-name -Wmissing-sysroot -Wmissing-variable-declarations
  -Wmodule-conflict -Wnested-anon-types -Wnewline-eof
  -Wnon-literal-null-conversion -Wnon-pod-varargs -Wnonportable-cfstrings
  -Wnull-arithmetic -Wnull-character -Wnull-conversion -Wnull-dereference
  -Wout-of-line-declaration -Wover-aligned -Woverlength-strings
  -Woverriding-method-mismatch -Wpointer-type-mismatch
  -Wpredefined-identifier-outside-function
  -Wprotocol-property-synthesis-ambiguity -Wreadonly-iboutlet-property
  -Wreceiver-expr -Wreceiver-forward-class -Wreinterpret-base-class
  -Wrequires-super-attribute -Wreserved-user-defined-literal
  -Wreturn-stack-address -Wsection -Wselector-type-mismatch -Wsentinel
  -Wserialized-diagnostics -Wshadow -Wshift-count-negative
  -Wshift-count-overflow -Wshift-negative-value -Wshift-sign-overflow
  -Wshorten-64-to-32 -Wsizeof-array-argument -Wsource-uses-openmp
  -Wstatic-float-init -Wstatic-in-inline -Wstatic-local-in-inline
  -Wstrict-overflow=1 -Wstring-compare -Wstring-conversion
  -Wstrlcpy-strlcat-size -Wstrncat-size -Wsuper-class-method-mismatch
  -Wswitch-bool -Wtautological-constant-out-of-range-compare
  -Wtentative-definition-incomplete-type -Wtype-safety -Wtypedef-redefinition
  -Wtypename-missing -Wundefined-inline -Wundefined-internal
  -Wundefined-reinterpret-cast -Wunicode -Wunicode-whitespace
  -Wunknown-warning-option -Wunnamed-type-template-args
  -Wunneeded-member-function -Wunsequenced -Wunsupported-visibility
  -Wunused-command-line-argument -Wunused-exception-parameter
  -Wunused-local-typedefs -Wunused-member-function -Wunused-volatile-lvalue
  -Wuser-defined-literals -Wvariadic-macros -Wvector-conversion
  -Wvector-conversions -Wvexing-parse -Wvisibility -Wvla-extension
  -Wzero-length-array -W -Wfloat-equal -Wundef -Wpointer-arith
  -Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings -Wredundant-decls
  -Wchar-subscripts -Wcomment -Wformat=2 -Wwrite-strings -Wnested-externs
  -Wbad-function-cast -Wswitch-enum -Waggregate-return -Wpacked -Wunused
  -Wunused-parameter -Wold-style-definition -Wmissing-declarations -Werror -MT
  src/core/or/src_core_libtor_app_testing_a-onion.o -MD -MP -MF
  src/core/or/.deps/src_core_libtor_app_testing_a-onion.Tpo -c -o
  src/core/or/src_core_libtor_app_testing_a-onion.o `test -f
  'src/core/or/onion.c' || echo './'`src/core/or/onion.c

With #27167, it has meant that travis is no longer willing to do do a full verbose clang build.

Child Tickets

Change History (8)

comment:1 Changed 4 weeks ago by catalyst

Keywords: tor-ci added

If the version of clang on Travis supports it, we could try using the @file option to put all the warning flags in a file instead of listing them on the command line. I'm not sure Travis has a recent enough clang to support that, and I know at least one clang I've tried in the past didn't support it when I needed it for something else.

Otherwise, we could remove --disable-silent-rules from our configure command line (or equivalently, setting V=0), maybe only conditionally on the clang builds?

comment:2 Changed 4 weeks ago by ahf

I read about it a bit this morning. Travis have a 4 MB upper limit on log size, after that builds get terminated.

comment:3 Changed 4 weeks ago by nickm

Owner: set to nickm
Status: newaccepted

comment:4 Changed 4 weeks ago by nickm

Actual Points: .1
Sponsor: Sponsor8-can
Status: acceptedneeds_review

Branch is shorter_logs_035; PR is https://github.com/torproject/tor/pull/614 .

Putting this in sponsor8 since it came up because of an s8 deliverable.

comment:5 Changed 4 weeks ago by catalyst

Status: needs_reviewmerge_ready

Looks good to me! Let's wait for CI to finish, including Appveyor (and maybe Jenkins), just to be sure, because we're doing this unconditionally.

comment:6 Changed 4 weeks ago by nickm

okay, I'll wait for appveyor. (Our jenkins doesn't test non-merged code.)

comment:7 Changed 4 weeks ago by nickm

Milestone: Tor: 0.4.0.x-finalTor: 0.3.5.x-final
Resolution: fixed
Status: merge_readyclosed

Okay, Appveyor is passing. Merged to 0.3.5 and forward.

comment:8 Changed 2 weeks ago by nickm

Added a missing changes file.

Note: See TracTickets for help on using tickets.