Opened 8 months ago

Closed 7 months ago

#28932 closed defect (fixed)

Detect when sbws stalls and log backtrace

Reported by: juga Owned by:
Priority: Medium Milestone: sbws: 1.0.x-final
Component: Core Tor/sbws Version: sbws: 1.0.2
Severity: Normal Keywords:
Cc: juga, teor Actual Points:
Parent ID: #28663 Points:
Reviewer: dgoulet Sponsor:

Description

Since it's possible that there will be other bug we haven't found yet, detect when sbws is stalling.
Also print backtrace so that operators can open tickets with the backtrace and help to find the bug.

Child Tickets

Change History (5)

comment:1 Changed 8 months ago by juga

Status: assignedneeds_review

comment:2 Changed 7 months ago by dgoulet

Reviewer: dgoulet

comment:3 Changed 7 months ago by dgoulet

Status: needs_reviewneeds_revision

I think we should make 36 value into some sort of constant because it isn't clear what is that value but also it is repeated twice.

I had to read the loop above to get that it is every 5 seconds and thus 36 is for 3 minutes. Either adding a clearer comment linking the two or making it a constant and comment there.

The other thing is that, don't you want to exit after the bug is detected or it will recover from the mistake?

Feel free to merge after that :).

comment:4 in reply to:  3 Changed 7 months ago by juga

Status: needs_revisionmerge_ready

Replying to dgoulet:

I think we should make 36 value into some sort of constant because it isn't clear what is that value but also it is repeated twice.

I had to read the loop above to get that it is every 5 seconds and thus 36 is for 3 minutes. Either adding a clearer comment linking the two or making it a constant and comment there.

Added a constant.

The other thing is that, don't you want to exit after the bug is detected or it will recover from the mistake?

No, the error doesn't recover. I changed the code so that it exits unless the debugging level is log (more verbose) so that it continues instanciating a Python Debugger (for developers to debug the error).

comment:5 Changed 7 months ago by juga

Resolution: fixed
Status: merge_readyclosed

Merged

Note: See TracTickets for help on using tickets.