Opened 9 months ago

Closed 7 months ago

Last modified 7 months ago

#28936 closed enhancement (wontfix)

Use Travis CI for goptlib.git repositories on Github

Reported by: ahf Owned by: dcf
Priority: Medium Milestone: Tor: unspecified
Component: Circumvention/Pluggable transport Version: Tor: unspecified
Severity: Minor Keywords: tor-pt goptlib
Cc: Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: dcf Sponsor: Sponsor19

Description

Members on the network team have been happy to use the Travis CI for tor.git in the past year or so.

Let's have the same for goptlib.git if some people are going to do development there and have their repositories located on Github.

Child Tickets

Change History (4)

comment:1 Changed 9 months ago by ahf

Reviewer: dcf
Status: newneeds_review

I don't know if this is the right place and method for doing patches to goptlib.git, but please let me know if you want them in a different way or format.

I've created a branch called features/travis on my Github clone of goptlib.git available at https://github.com/ahf/goptlib/commits/features/travis

The Travis configuration file is made to build and test goptlib against Go versions currently supported by supported Debian versions (jessie to buster) and against Go's master branch (but we don't do a hard failure if our build/test fails on that).

The builder reports success/failure in the #tor-ci IRC channel on OFTC.

The "raw" patch can be seen at https://github.com/ahf/goptlib/commit/9cd78a619149fca8576dfa57b797ca11204ba4ba.patch

An example run from Travis is available at https://travis-ci.org/ahf/goptlib/builds/471433419

comment:2 Changed 9 months ago by dcf

Keywords: goptlib added
Owner: changed from asn to dcf
Status: needs_reviewassigned

Thanks for doing this. I am skeptical of this, partly because of an aversion to dotfile cruft but also because I don't want to add new dependency on GitHub (which, let's not forget, is f*‍*‍*ing Microsoft).

In any case, I don't think that reporting to #tor-ci is appropriate for other people's forks that don't necessarily have to do with Tor.

comment:3 Changed 7 months ago by ahf

Resolution: wontfix
Status: assignedclosed

Closing this. I agree with what dcf said. Let's look into CI when we have a Gitlab instance.

comment:4 Changed 7 months ago by ahf

Actual Points: 0.1
Points: 0.1
Note: See TracTickets for help on using tickets.